Skip to content

Asevr/kg 533 readfiletool empty files as binary #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annajetbrains wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Asevr/kg 533 readfiletool empty files as binary #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14fc2c9
KG-533 ReadFileTool incorrectly reports empty files as binary: checki…
annajetbrains Jan 8, 2026
a589877
KG-533 ReadFileTool incorrectly reports empty files as binary: update…
annajetbrains Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion agents/agents-ext/src/commonMain/kotlin/ai/koog/agents/ext/tool/file/ReadFileTool.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ public class ReadFileTool<Path>(private val fs: FileSystemProvider.ReadOnly<Path
validate(metadata.type == FileMetadata.FileType.File) { "Not a file: ${args.path}" }

val type = fs.getFileContentType(path)
validate(type == FileMetadata.FileContentType.Text) { "File is not a text file: ${args.path}" }
val isEmpty = fs.size(path) == 0L
val isText = isEmpty || (type == FileMetadata.FileContentType.Text)
validate(isText) { "File is not a text file: ${args.path}" }

return runCatching {
var warningMessage: String? = null
Expand Down
28 changes: 20 additions & 8 deletions agents/agents-ext/src/jvmTest/kotlin/ai/koog/agents/ext/tool/file/ReadFileToolJvmTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,17 @@ class ReadFileToolJvmTest {
}

@Test
fun `throws ValidationFailure when reading empty markdown file`() {
fun `reading empty markdown file renders empty fenced block`() = runBlocking {
val f = createTestFile("empty.md", "")
assertThrows<ToolException.ValidationFailure> {
runBlocking { readFile(f) }
}
val result = readFile(f)
val expected = """
${"${f.toAbsolutePath().toString().norm()} (0 bytes, 1 line)"}
Content:
```markdown
```
""".trimIndent()

assertEquals(expected, tool.encodeResultToString(result))
}

@Test
Expand Down Expand Up @@ -249,11 +255,17 @@ class ReadFileToolJvmTest {
}

@Test
fun `throws ValidationFailure when reading empty kotlin file`() {
fun `reading empty kotlin file renders empty fenced block`() = runBlocking {
val f = createTestFile("Empty.kt", "")
assertThrows<ToolException.ValidationFailure> {
runBlocking { readFile(f) }
}
val result = readFile(f)
val expected = """
${"${f.toAbsolutePath().toString().norm()} (0 bytes, 1 line)"}
Content:
```kotlin
```
""".trimIndent()

assertEquals(expected, tool.encodeResultToString(result))
}

@Test
Expand Down