KT-20357: Add getOrElse sample for Collections #5482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hondaya14
force-pushed
the
sample-collections
branch
from
c033094 to
ccd949a
Compare
hondaya14
force-pushed
the
sample-collections
branch
from
ccd949a to
045cbe0
Compare
fzhinkin
added
the
Standard Library Sample
fzhinkin
requested changes
Aug 11, 2025
| @@ -1467,6 +1467,8 @@ public inline fun CharArray.firstOrNull(predicate: (Char) -> Boolean): Char? { | |||
|
|
|||
| /** | |||
| * Returns an element at the given [index] or the result of calling the [defaultValue] function if the [index] is out of bounds of this array. | |||
| * | |||
| * @sample samples.collections.Collections.Elements.getOrElse | |||
There was a problem hiding this comment.
It would be nice to provide dedicated samples for array types (like it was done for contentEquals, for example: 658323f)
There was a problem hiding this comment.
I added samples for array types. I opted not to introduce per-type methods (e.g. contentEquals), since that would be verbose and slightly reduce readability.
(ref: bdcf70b)
I’m unsure about the class structure—especially the sample subclass categorization—so I may be mistaken. Feedback would be appreciated.
|
@fzhinkin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a sample function for
getOrElseinCollections.There was already a sample for
Map, but none forCollections.Related issue: https://youtrack.jetbrains.com/issue/KT-20357