Skip to content

Sync versions of apps, add script to update all versions, add version to About screen#348

Merged
zsmb13 merged 1 commit intokotlinconf-2025from
versioning
Mar 26, 2025
Merged

Sync versions of apps, add script to update all versions, add version to About screen#348
zsmb13 merged 1 commit intokotlinconf-2025from
versioning

Conversation

@zsmb13
Copy link
Collaborator

@zsmb13 zsmb13 commented Mar 24, 2025

image

@zsmb13 zsmb13 changed the title wip versioning Sync versions of apps, add script to update all versions, add version to About screen Mar 24, 2025
@zsmb13 zsmb13 requested a review from e5l March 24, 2025 16:22
@zsmb13 zsmb13 marked this pull request as ready for review March 24, 2025 22:12
versionCode = 38
versionName = "38.0"
versionCode = 62
versionName = "25.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, we can't go back in time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only the user-visible version string on Android, as far as I know, we can pick any arbitrary value for it. There's nothing checking that it increments over time.

https://developer.android.com/studio/publish/versioning#versioningsettings

"@executable_path/Frameworks",
);
MARKETING_VERSION = 3.2.2;
MARKETING_VERSION = 25.0.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change will trigger long full app review after submission. I would avoid this for minor updates

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to have one full app review for the 2025 version anyway?

Do you think we should stick with 3.x.x for the entire 2025 year instead? (In that case, we'd have to change the Android version to that as well.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually have a short one for the patch updates

@zsmb13 zsmb13 requested a review from e5l March 25, 2025 14:58
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks better

@zsmb13 zsmb13 merged commit e6ad795 into kotlinconf-2025 Mar 26, 2025
5 checks passed
@zsmb13 zsmb13 deleted the versioning branch March 26, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants