[oisano (oisano11)]

Summary

Closes the gap between en.json and the bundled zh-CN.json on current main: 2630 keys in English, 2532 in Chinese. A missing key falls back to English silently, because check:i18n validates en.json only, so the Chinese interface has been drifting toward half-English as the app grew.

The gaps are strings added or rewritten upstream after the catalog was last completed in #871: the connect-a-provider and onboarding surfaces, the new-project dialog, custom themes, analytics consent, the auth prompt fragments, and the background-work dock and inspector that #1004 added. Nothing was lost in a merge; these keys post-date the translations.

Two commits, one file, +98 lines.

Changes

• packages/locales/zh-CN.json: 2532 → 2630 keys, every key en.json declares. validateCatalog drops nothing, so the coverage is real rather than nominal.
  • First commit (+79): the keys missing when this PR was opened.
  • Second commit (+19): the resources.* keys from feat(resources): keep finished background work out of the dock and persist each chat's history across restarts #1004 (resources.dock.finished, resources.inspector.showMore, resources.state.interrupted, …), added after a rebase onto df7cb6d2.
• Both plural families (panels.connectProvider.modelsAvailable_*, panels.welcome.connectedModels_*) get _one and _other, following how the other bundled catalogs are written even though Intl.PluralRules("zh-CN") only resolves other.

Terminology follows what the catalog already settled on: provider 提供方, host/agent/spec/Skill left as-is, subagent 子 agent, finished 已结束, workspace 工作区, plan (the subscription) 套餐, repo 仓库, and — (spaced em dash) rather than ——. Address forms split the way the file already splits them: 您 in the longer explanatory copy, 你 in short status lines.

Strings that needed care:

• auth.login.promptBlankFor is spliced mid-sentence by loginOptions.ts:28, which is why the English value deliberately starts with .; the Chinese starts with 。 to match.
• settings.appearance.custom.steps keeps its <0>dark.theme.json</0> marker, which CustomThemesSettings.tsx renders as a clickable example.
• resources.inspector.foldLabel and resources.inspector.showMore keep all their placeholders ({{count}}, {{done}}, {{failed}}, {{stopped}}, {{left}}); a script checked every new value's placeholder set against English.

Testing

• bun test packages/locales/src/ → 48 pass / 0 fail, including the three bundled-catalog tests (every string validates against English, key set legal and sorted, every plural family complete)
• bun run check:i18n → check-i18n: OK (no hardcoded UI text; catalog sorted and fully referenced; no render-time global translator)
• bunx turbo run typecheck → 25/25
• bunx biome check packages/locales/zh-CN.json → clean
• bunx turbo run test --filter=@thinkrail/locales --filter=@thinkrail/web → 48 + 1976 pass / 0 fail
• Not verified: e2e and a desktop smoke run, same as feat(locales): add a Simplified Chinese catalog #866 and feat(locales): complete the Simplified Chinese catalog #871

[oisano (oisano11)]

Fork-PR note, same as #866 / #871 / #882: the workflow is sitting at action_required, so nothing has run yet. Could a maintainer approve it?

A couple of things worth knowing before you read the diff:

Why the gap appeared. check:i18n validates en.json only — it checks the catalog is sorted and every key is referenced, but not that the other bundled catalogs cover it. So a missing translation is silent: the key falls back to English at render time and nothing goes red. That is how the catalog drifted 77 keys behind without anyone noticing. I did not change the gate in this PR; if you would rather the bundled catalogs were held to full coverage, that is a separate change and I am happy to write it.

How I picked the wording. The catalog already has 2525 strings, so the terminology was settled before I got here: provider 提供方, repo 仓库, plan (the subscription) 套餐, host/agent/spec/Skill left in English, and — rather than —— (which appears nowhere in the file). Address forms follow the existing split — 您 in the longer explanatory copy, 你 in short status lines.

Two strings that are not straight translations.

• auth.login.promptBlankFor is spliced mid-sentence by apps/web/src/auth/loginOptions.ts:28 — that is why the English value deliberately begins with .. The Chinese begins with 。.
• settings.appearance.custom.steps keeps its <0>dark.theme.json</0> marker; CustomThemesSettings.tsx renders it as the clickable example.

Both plural families carry _one and _other even though Intl.PluralRules("zh-CN") only resolves other, matching how the other bundled catalogs are written.

[jetbrains-air]

Approved — ready to merge.

[Olga Lavrichenko (OLavrik)]

Verified mechanically: key sets are identical to en.json (2604 = 2604, nothing missing or extra), and every one of the 79 added keys preserves the English placeholders and ICU markers — including the mid-sentence auth.login.promptBlankFor (leading 。 + {{fallback}}) and the clickable <0>dark.theme.json</0> marker in settings.appearance.custom.steps. Both new plural families keep _one and _other with {{count}}, and the only catalog-wide placeholder gaps are pre-existing _one variants that zh-CN never resolves. Terminology matches the existing catalog. Approving.

[oisano (oisano11)]

Rebased onto df7cb6d2 and added one commit (0b13ac6d, +19) for the resources.* keys that #1004 introduced, so zh-CN.json now matches en.json key for key (2630). The first commit is unchanged apart from the rebase. Gates are green locally (details in the description). The fork workflow is at action_required again and needs approval to run.

[jetbrains-air]

Approved — ready to merge.