Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test ci merge commit #2

Closed
wants to merge 1 commit into from

Conversation

JohnRTitor
Copy link
Owner

@JohnRTitor JohnRTitor commented Dec 3, 2024

FOR TESTING THE EVAL ACTION

@JohnRTitor JohnRTitor force-pushed the ci-merge-commit branch 2 times, most recently from 893039e to aa7ba08 Compare December 3, 2024 17:50
@JohnRTitor JohnRTitor force-pushed the test-ci-merge-commit branch 2 times, most recently from 41100a3 to bab6f85 Compare December 3, 2024 18:15
@JohnRTitor JohnRTitor force-pushed the test-ci-merge-commit branch from bab6f85 to b50affa Compare December 4, 2024 16:55
@JohnRTitor JohnRTitor force-pushed the test-ci-merge-commit branch from b50affa to 964943b Compare December 4, 2024 19:14
@JohnRTitor JohnRTitor force-pushed the test-ci-merge-commit branch from 964943b to c135edd Compare December 4, 2024 19:36
FOR TESTING THE EVAL ACTION
@JohnRTitor JohnRTitor force-pushed the test-ci-merge-commit branch from c135edd to 28f1e0b Compare December 6, 2024 15:56
@JohnRTitor JohnRTitor closed this Dec 29, 2024
JohnRTitor pushed a commit that referenced this pull request Jan 5, 2025
nixosTests.cryptpad started failing recently.

Investigating the issue shows that seccomp has become problematic during
the init phase, (e.g. this can be reproduced by removing the customize
directory in /var/lib/cryptpad):

machine # [   10.774365] systemd-coredump[864]: Process 756 (node) of user 65513 dumped core.
machine #
machine # Module libgcc_s.so.1 without build-id.
machine # Module libstdc++.so.6 without build-id.
machine # Module libicudata.so.74 without build-id.
machine # Module libicuuc.so.74 without build-id.
machine # Module libicui18n.so.74 without build-id.
machine # Module libz.so.1 without build-id.
machine # Module node without build-id.
machine # Stack trace of thread 756:
machine # #0  0x00007ff951974dcb fchown (libc.so.6 + 0x107dcb)
machine # #1  0x00007ff95490d0c0 uv__fs_copyfile (libuv.so.1 + 0x150c0)
machine # #2  0x00007ff95490d89a uv__fs_work (libuv.so.1 + 0x1589a)
machine # #3  0x00007ff954910c76 uv_fs_copyfile (libuv.so.1 + 0x18c76)
machine # NixOS#4  0x0000000000eb8a39 _ZN4node2fsL8CopyFileERKN2v820FunctionCallbackInfoINS1_5ValueEEE (node + 0xab8a39)
machine # NixOS#5  0x0000000001cda5e2 Builtins_CallApiCallbackGeneric (node + 0x18da5e2)
[...]
machine # [   10.877468] cryptpad[685]: /nix/store/h4yhhxpfm03c5rgz91q7jrvknh596ly2-cryptpad-2024.12.0/bin/cryptpad: line 3:   756 Bad system call         (core dumped) "/nix/store/fkyp1bm5gll9adnfcj92snyym524mdrj-nodejs-22.11.0/bin/node" "/nix/store/h4yhhxpfm03c5rgz91q7jrvknh596ly2-cryptpad-2024.12.0/lib/node_modules/cryptpad/scripts/build.js"

nodejs 20.18 rightly did not require chown when the source and
destination are the same owner (heck, the script does not run as
root so even if it is not blocked there is no way it'd work with a
different owner...)

For now just allow chown calls again, this is not worth wasting more
time.

Fixes NixOS#370717
@JohnRTitor JohnRTitor deleted the test-ci-merge-commit branch January 7, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant