fixed color=false disables coloured output for log messages, not rest of the output - Issue #911

[18c83fd3-25ea-4ed9-8205-2abeff9b3883]

I've fixed the issue where setting color = false in joinmarket.cfg only disabled colored output for log messages but not for other console output.

The fix involved three changes to src/jmbase/support.py:

Added a global variable to track the color setting:

• Global variable to track whether colored output is enabled
  colored_output = [True]

• Modified the jmprint() function to respect this setting:

if sys.stdout.isatty() and colored_output[0]:
print(jm_colorizer.colorize_message(fmtd_msg))
else:
print(fmtd_msg)

• Updated the set_logging_color() function to set this global variable:

def set_logging_color(colored=False):
# Update the global colored_output setting
colored_output[0] = colored
if colored and sys.stdout.isatty():
handler.colorizer = jm_colorizer
else:
handler.colorizer = MonochromaticColorizer()

Now when a user sets color = false in joinmarket.cfg, it will disable colored output for both log messages and direct console output via jmprint().

[18c83fd3-25ea-4ed9-8205-2abeff9b3883]

?

[Copilot]

Pull Request Overview

This PR ensures that the color = false setting in joinmarket.cfg now fully disables colored output for both log messages and direct console prints via jmprint().

• Introduces a global flag to track color output
• Updates jmprint() to respect the color flag
• Modifies set_logging_color() to update the new flag

Comments suppressed due to low confidence (2)

src/jmbase/support.py:202

• The new colored_output flag and its effect on jmprint() should be documented in a module or function docstring so users understand how set_logging_color influences both logging and direct prints.

def set_logging_color(colored=False):

src/jmbase/support.py:187

• Add unit tests for jmprint to verify behavior with colored_output toggled on and off, and in both TTY and non-TTY environments to prevent regressions.

    if sys.stdout.isatty() and colored_output[0]:

[Copilot]

[nitpick] Consider using a simple boolean global (e.g., colored_output_enabled: bool) with a global declaration in set_logging_color instead of a single-element list, which can be confusing for future maintainers.

Suggested change

	colored_output = [True]
	colored_output_enabled = True

[roshii]

Some tweaks are needed imo.

[roshii]

Should be removed imo

[roshii]

Simple boolean is best suited imo