feat(config): override config with environment variables #1823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for overriding JoinMarket configuration settings via environment variables, enabling easier deployment in containerized environments and CI/CD pipelines.
Changes
Core Functionality
override()function that reads environment variables prefixed withJM_and applies them to the configurationJM_MESSAGING_ONION_TYPE=onionmaps to[MESSAGING:onion] type=onion)Refactoring
load_program_config()into smaller, focused functions:set_paths()- handles data directory and config file path setupread_config_file()- reads existing config file with error handlingwrite_config_file()- creates new default config file\Usage Examples
Benefits
This feature follows the common pattern of using prefixed environment variables for configuration overrides, making JoinMarket more suitable for modern deployment workflows.