This repository was archived by the owner on May 13, 2022. It is now read-only.
segwit backend support #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary PR to add the routines for: serializing, deserializing and signing/verifying (p2sh-p2wpkh only for the latter) segwit transactions. The tests added are minimal: just testing correct parsing of valid segwit transactions.
The further code needed is: (a) add segwit wallet code (b) add 'sw' (rel/abs) orders, (c) modifications to maker and taker code to support (a) and (b). That code already basically exists in AdamISZ/joinmarket segwit branch, but there are a number of points still open to discussion, which can already be found in issues from last year.
When that code is added, will need to add a number of further test (vectors).