Fixing issue with duplicate live query events after unsubscribe #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue with duplicate live query events after unsubscribe by removing subscriptions in unsubscribe method.
Repro scenario:
private ParseLiveQueryClient _client;
private ParseQuery _query;
private Subscription _sub;
public void InitLiveQuery() {
var cfg = new ParseClient.Configuration(...);
ParseClient.Initialize(cfg);
_client = new ParseLiveQueryClient(new Uri(serverUrl));
}
public void StartLiveQuery(string className, string objectId) {
_client.Reconnect();
_query = new ParseQuery(className);
if (!string.IsNullOrEmpty(objectId)) _query = _query.WhereEqualTo("objectId", objectId);
_sub = _client.Subscribe(_query);
_sub.HandleEvents(HandleLiveQueryEvent);
_sub.HandleError(HandleLiveQueryError);
}
public void StopLiveQuery() {
_client.Unsubscribe(_query, _sub);
_client.Disconnect();
_query = null;
_sub = null;
}
InitLiveQuery();
//not receiving live query update callbacks
StartLiveQuery();
//receiving live query update callbacks
StopLiveQuery();
//still receiving live query update callbacks
StartLiveQuery();
//receiving duplicate live query update callbacks
Root cause: subscriptions not being removed from subscription dictionary on unsubscribe.
Fix: removing subscriptions from subscription dictionary in unsubscribe method