Skip to content

Fix search dialog close on touch devices (iPad without keyboard) #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −6
Draft

Fix search dialog close on touch devices (iPad without keyboard) #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47c6d16
Initial plan
Copilot Mar 12, 2026
b03f66b
Fix: Make search dialog closeable on touch devices (iPad) without ESC…
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions components/search.templ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ templ SearchButton(args SearchButtonArgs) {
templ searchDialog(args SearchButtonArgs) {
<dialog
id="search-dialog"
onclick="if(event.target===this)this.close()"
class="backdrop:o-backdrop-blur-sm o-max-w-prose o-w-full o-h-full o-px-4 sm:o-px-0 o-bg-transparent"
>
<div class="o-h-full o-flex o-flex-col">
Expand All @@ -138,12 +139,13 @@ templ searchDialog(args SearchButtonArgs) {
</div>
<div class="o-flex o-gap-3 o-justify-between o-items-center o-border-t o-border-t-black/10 dark:o-border-t-white/10 o-p-3">
@loadingTagSelectors()
<div
class="o-inline-flex o-gap-2 o-items-center o-text-sm dark:o-text-white"
<button
onclick="this.closest('dialog').close()"
class="o-inline-flex o-gap-2 o-items-center o-text-sm dark:o-text-white o-cursor-pointer"
>
<span class="o-text-caption">Close</span>
@KBD("esc")
</div>
</button>
</div>
</div>
@SearchResults(SearchResultsArgs{})
Expand Down
6 changes: 3 additions & 3 deletions components/search_templ.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.