Skip to content

Models that fail integration tests but defy isolation #1085

Description

@ablaom

Integration tests (contained in the new file /test/integration.tl) fail for a few models in very subtle ways I have been unable to nail down after several days of trying. The models are:

  • AdaBoostStumpClassifier (interface package: MLJDecisionTreeInterface)
  • COFDetector (interface package :OutlierDetectorNeighbors)

If I run ] test MLJ the models fail, but if I manually execute the /test/integration.tl script, the models pass. I have carefully compared the two environment manifests that appear to be operating in the two cases and they are identical. I can see no trace of some RNG-related difference.

For now I have excluded the models from integration tests, with a reference to this issue in the test code.

Note that to force integration tests to run, you must set the env variable MLJ_TEST_INTEGRATION="true".

edit

Adding to this list:

  • TSVDTransform

Passes tests locally but fails in CI.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    invalidThis doesn't seem right

    Type

    No type

    Projects

    • Status
      priority low / involved

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions