Update RectDiagonal broadcasting to accept 2-element size #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
===========================================
+ Coverage 0.00% 99.82% +99.82%
===========================================
Files 8 8
Lines 1152 1156 +4
===========================================
+ Hits 0 1154 +1154
+ Misses 1152 2 -1150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
can you add a test that fails without this change? |
Member
Author
|
Tests already exist and are failing on v1.13 alpha. The CI failures on the master branch currently should be resolved by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinearAlgebranow passes the 2-elementsizeof the matrix tostructured_broadcast_alloc. This adapts the method in this package to accept the 2-termsize. This would be backward compatible, asminimumis a no-op for a number.The change here gets tests working on julia v1.14.