Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Dec 17, 2025

Most of these reshape methods are simply to avoid method ambiguities with Base. I am planning an overhaul of the reshape methods in Base in JuliaLang/julia#56850, after which a large fraction of these methods may be removed (or version-capped). This PR is to update the methods to dispatch on Tuples with at least one argument, which firstly avoids any ambiguities with an empty Tuple, and secondly makes this package more resilient to changes to Base.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.74%. Comparing base (0a58cd8) to head (375c0a6).

Files with missing lines Patch % Lines
src/FillArrays.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #425       +/-   ##
===========================================
+ Coverage    0.00%   99.74%   +99.74%     
===========================================
  Files           8        8               
  Lines        1152     1155        +3     
===========================================
+ Hits            0     1152     +1152     
+ Misses       1152        3     -1149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dlfivefifty dlfivefifty self-requested a review December 18, 2025 18:54
Copy link
Member

@dlfivefifty dlfivefifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests that pick up the ambiguities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants