Draft: address unsafe pointer operations (segfaults on nightly)#196
Closed
sefffal wants to merge 6 commits intoJuliaAstro:masterfrom
Closed
Draft: address unsafe pointer operations (segfaults on nightly)#196sefffal wants to merge 6 commits intoJuliaAstro:masterfrom
sefffal wants to merge 6 commits intoJuliaAstro:masterfrom
Conversation
Member
|
I think it's fine to remove the reinterpreted complex tests (I was the one who had added these). These aren't relevant for the package as such. |
Member
Author
|
Doing some digging again, and it looks like one of the causes of errors is FITS tables with string columns, due, I'm guessing, to changes to how the |
Member
|
The issue on master has been fixed now, so this PR should not be necessary anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes begin to address the unsafe operations used in this package.
Currently these just deal with the most obvious issues.
Repeatedly running tests on nightly reveal that there are still segfaults. I believe we are leaking pointers to C somewhere. This will also have to be addressed.
Note that tests are failing due to an unrelated issue with complex arrays that also impacts nightly.
Edit: there are some unrelated changes in the first three commits I will excise from this PR.