Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Makie plotting #56

Merged
merged 4 commits into from
Jan 12, 2025
Merged

add Makie plotting #56

merged 4 commits into from
Jan 12, 2025

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Jan 11, 2025

Plots AbstractSkyCoords as x=lon, y=lat.
Also, add (unexported) lonlat function – I think it's generally useful.

One issue with testing: loading python packages (like astropy) and Makie together leads to segfaults. Currently, commented out astropy tests, but not sure what's the best approach.

@cgarling
Copy link
Member

If you isolate the astropy and makie tests with SafeTestsets.jl do the segfaults persist?

@aplavin
Copy link
Contributor Author

aplavin commented Jan 11, 2025

I think the segfault is caused by two conflicting shared libraries loaded into the same process, it's not julia module related.

test/runtests.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (8e1c7e4) to head (db4e804).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
ext/UnitfulExt.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   94.48%   90.90%   -3.58%     
==========================================
  Files           5        6       +1     
  Lines         145      165      +20     
==========================================
+ Hits          137      150      +13     
- Misses          8       15       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano giordano merged commit 87db735 into JuliaAstro:master Jan 12, 2025
12 of 14 checks passed
@aplavin
Copy link
Contributor Author

aplavin commented Jan 12, 2025

Thanks for the assistance and a quick merge! Would you also register this please?

@giordano
Copy link
Member

That's easier to do when you also bump the version within the PR you're proposing, as someone else will have to do that anyway.

@aplavin aplavin deleted the plot branch January 14, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants