Skip to content

support any <:Real component types #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Jan 30, 2025

Fix #58 to enable integration with other Real types from packages.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (8e1c7e4) to head (1ea3f52).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/types.jl 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   94.48%   90.90%   -3.58%     
==========================================
  Files           5        6       +1     
  Lines         145      165      +20     
==========================================
+ Hits          137      150      +13     
- Misses          8       15       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aplavin
Copy link
Contributor Author

aplavin commented Jan 30, 2025

Failure on windows is purely python-related.

@aplavin
Copy link
Contributor Author

aplavin commented Feb 6, 2025

bump...

@giordano giordano merged commit c8ae628 into JuliaAstro:master Feb 6, 2025
11 of 14 checks passed
@aplavin aplavin deleted the real branch February 10, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax AbstractFloat to Real
2 participants