Skip to content

Allow for benchmarking with MPI #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abussy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow for benchmarking with MPI #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/runbenchmark.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
end

juliacmd = benchmarkconfig.juliacmd
juliacmd = `$(Base.julia_cmd(juliacmd[1])) $color $(juliacmd[2:end])`
juliacmd = `$(Base.julia_cmd(juliacmd)) $color`

target_env = [k => v for (k, v) in benchmarkconfig.env]
withenv(target_env...) do
Expand Down Expand Up @@ -291,12 +291,16 @@
vinfo = first(split(sprint((io) -> versioninfo(io; verbose=true)), "Environment"))
juliasha = Base.GIT_VERSION_INFO.commit

open(output, "w") do iof
# Atomic write to the output file
temp_output = tempname()
open(temp_output, "w") do iof

Check warning on line 296 in src/runbenchmark.jl

View check run for this annotation

Codecov / codecov/patch

src/runbenchmark.jl#L295-L296 

Added lines #L295 - L296 were not covered by tests
JSON.print(iof, Dict(
"results" => sprint(BenchmarkTools.save, results),
"vinfo" => vinfo,
"juliasha" => juliasha,
))
end
mv(temp_output, output; force=true)

Check warning on line 303 in src/runbenchmark.jl

View check run for this annotation

Codecov / codecov/patch

src/runbenchmark.jl#L303 

Added line #L303 was not covered by tests

return nothing
end
Loading