Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eindhoven dining info #595

Merged
merged 11 commits into from
Jul 2, 2024
Merged

Conversation

el-oso
Copy link
Contributor

@el-oso el-oso commented Jul 2, 2024

Briefly Describe your changes

Checklist for merge

  • I built the website locally and tested it using Franklin.serve()
  • All CI checks have passed and you have tested the online version (click on the list of checks and click Build and Deploy / Preview to see the preview)
  • Somebody else reviewed my changes (use your best judgement if you need to merge quickly

After merge

  • Closed relevant issues

Copy link
Contributor

@cormullion cormullion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“dining” rather than “dinning” 😀

@bvdmitri
Copy link
Collaborator

bvdmitri commented Jul 2, 2024

@cormullion can we merge?

@giordano giordano changed the title Eindhoven dinning info Eindhoven dining info Jul 2, 2024
@cormullion
Copy link
Contributor

Of course! (I learnt today that "dinning" is Dutch for "dining" 😀

@bvdmitri bvdmitri merged commit 2b7c95a into JuliaCon:franklin Jul 2, 2024
1 check passed
@el-oso
Copy link
Contributor Author

el-oso commented Jul 2, 2024

@cormullion ... except ... that I am not Dutch 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants