Skip to content

Fix @where deprecation warning #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdeffebach merged 3 commits into from
Jul 23, 2021
Merged

Fix @where deprecation warning #271

pdeffebach merged 3 commits into from
Jul 23, 2021

Conversation

@etpinard
Copy link
Contributor

@etpinard etpinard commented Jul 23, 2021 •
edited
Loading

which mentions an unexported @skipmissing, which never got implemented.

Judging from

https://github.com/pdeffebach/DataFramesMeta.jl/blob/8d55422f7f95fd8008fc895b54dc457506a19352/src/macros.jl#L428

and

https://github.com/pdeffebach/DataFramesMeta.jl/blob/8d55422f7f95fd8008fc895b54dc457506a19352/src/macros.jl#L436

added in #263, the skipmissing kwarg is set to true already by default when calling @subset and @subset!. So @subset appears to be a drop-in replacement for @where without having to do extra work.

@etpinard
fix @where deprecation warning
abd0513 
which mention an unexported `@skipmissing`
which never got implemented
@etpinard
Copy link
Contributor Author

etpinard commented Jul 23, 2021

test logs 
(DataFramesMeta) pkg> test
     Testing DataFramesMeta
      Status `/tmp/jl_HVdJwE/Project.toml`
  [324d7699] CategoricalArrays v0.10.0
  [8be319e6] Chain v0.4.7
  [a93c6f00] DataFrames v1.2.1
  [1313f7d8] DataFramesMeta v0.8.0 `~/.julia/dev/DataFramesMeta`
  [50d2b5c4] Lazy v0.15.1
  [1914dd2f] MacroTools v0.5.6
  [189a3867] Reexport v1.1.0
  [9a3f8284] Random `@stdlib/Random`
  [10745b16] Statistics `@stdlib/Statistics`
  [8dfed614] Test `@stdlib/Test`
      Status `/tmp/jl_HVdJwE/Manifest.toml`
  [324d7699] CategoricalArrays v0.10.0
  [8be319e6] Chain v0.4.7
  [34da2185] Compat v3.31.0
  [a8cc5b0e] Crayons v4.0.4
  [9a962f9c] DataAPI v1.7.0
  [a93c6f00] DataFrames v1.2.1
  [1313f7d8] DataFramesMeta v0.8.0 `~/.julia/dev/DataFramesMeta`
  [864edb3b] DataStructures v0.18.9
  [e2d170a0] DataValueInterfaces v1.0.0
  [59287772] Formatting v0.4.2
  [41ab1584] InvertedIndices v1.0.0
  [82899510] IteratorInterfaceExtensions v1.0.0
  [682c06a0] JSON v0.21.1
  [50d2b5c4] Lazy v0.15.1
  [1914dd2f] MacroTools v0.5.6
  [e1d29d7a] Missings v1.0.0
  [bac558e1] OrderedCollections v1.4.1
  [69de0a69] Parsers v1.1.0
  [2dfb63ee] PooledArrays v1.2.1
  [08abe8d2] PrettyTables v1.1.0
  [3cdcf5f2] RecipesBase v1.1.1
  [189a3867] Reexport v1.1.0
  [a2af1166] SortingAlgorithms v1.0.1
  [856f2bd8] StructTypes v1.7.2
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.4.4
  [0dad84c5] ArgTools `@stdlib/ArgTools`
  [56f22d72] Artifacts `@stdlib/Artifacts`
  [2a0f44e3] Base64 `@stdlib/Base64`
  [ade2ca70] Dates `@stdlib/Dates`
  [8bb1440f] DelimitedFiles `@stdlib/DelimitedFiles`
  [8ba89e20] Distributed `@stdlib/Distributed`
  [f43a241f] Downloads `@stdlib/Downloads`
  [9fa8497b] Future `@stdlib/Future`
  [b77e0a4c] InteractiveUtils `@stdlib/InteractiveUtils`
  [b27032c2] LibCURL `@stdlib/LibCURL`
  [76f85450] LibGit2 `@stdlib/LibGit2`
  [8f399da3] Libdl `@stdlib/Libdl`
  [37e2e46d] LinearAlgebra `@stdlib/LinearAlgebra`
  [56ddb016] Logging `@stdlib/Logging`
  [d6f4376e] Markdown `@stdlib/Markdown`
  [a63ad114] Mmap `@stdlib/Mmap`
  [ca575930] NetworkOptions `@stdlib/NetworkOptions`
  [44cfe95a] Pkg `@stdlib/Pkg`
  [de0858da] Printf `@stdlib/Printf`
  [3fa0cd96] REPL `@stdlib/REPL`
  [9a3f8284] Random `@stdlib/Random`
  [ea8e919c] SHA `@stdlib/SHA`
  [9e88b42a] Serialization `@stdlib/Serialization`
  [1a1011a3] SharedArrays `@stdlib/SharedArrays`
  [6462fe0b] Sockets `@stdlib/Sockets`
  [2f01184e] SparseArrays `@stdlib/SparseArrays`
  [10745b16] Statistics `@stdlib/Statistics`
  [fa267f1f] TOML `@stdlib/TOML`
  [a4e569a6] Tar `@stdlib/Tar`
  [8dfed614] Test `@stdlib/Test`
  [cf7118a7] UUIDs `@stdlib/UUIDs`
  [4ec0a83e] Unicode `@stdlib/Unicode`
  [deac9b47] LibCURL_jll `@stdlib/LibCURL_jll`
  [29816b5a] LibSSH2_jll `@stdlib/LibSSH2_jll`
  [c8ffd9c3] MbedTLS_jll `@stdlib/MbedTLS_jll`
  [14a3606d] MozillaCACerts_jll `@stdlib/MozillaCACerts_jll`
  [83775a58] Zlib_jll `@stdlib/Zlib_jll`
  [8e850ede] nghttp2_jll `@stdlib/nghttp2_jll`
  [3f19e933] p7zip_jll `@stdlib/p7zip_jll`
Precompiling project...
  1 dependency successfully precompiled in 2 seconds (28 already precompiled)
     Testing Running tests...
Running tests:
Test Summary: | Pass  Total
@transform    |   35     35
Test Summary:          | Pass  Total
@transform with :block |    5      5
Test Summary: | Pass  Total
@transform!   |   36     36
Test Summary:           | Pass  Total
@transform! with :block |    5      5
Test Summary:        | Pass  Total
limits of @transform |    8      8
Test Summary: | Pass  Total
@select       |   34     34
Test Summary:      | Pass  Total
select with :block |    5      5
Test Summary: | Pass  Total
@select!      |   36     36
Test Summary:        | Pass  Total
@select! with :block |    5      5
Test Summary:     | Pass  Total
limits of @select |    8      8
Test Summary:             | Pass  Total
Keyword arguments failure |    2      2
Test Summary: | Pass  Total
with          |   13     13
┌ Warning: Using an un-quoted Symbol on the LHS is deprecated. Write Symbol("##340") = ... instead.
│   caller = ip:0x0
└ @ Core :-1
Test Summary: | Pass  Total
orderby       |    5      5
Test Summary:       | Pass  Total
orderby with :block |    5      5
Test Summary:         | Pass  Total
cols with @select fix |    4      4
Test Summary:  | Pass  Total
removing lines |    6      6
        PASSED: dataframes.jl
Test Summary: | Pass  Total
eachrow       |   10     10
Test Summary:      | Pass  Total
cols with @eachrow |    7      7
Test Summary:      | Pass  Total
limits of @eachrow |    4      4
Test Summary: | Pass  Total
eachrow!      |   12     12
        PASSED: eachrow.jl
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
Test Summary: | Pass  Total
@combine      |   35     35
Test Summary:       | Pass  Total
combine with :block |    4      4
Test Summary:      | Pass  Total
Limits of @combine |    3      3
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1475
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1475
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1475
Test Summary: | Pass  Total
@by           |   35     35
Test Summary:  | Pass  Total
by with :block |    4      4
Test Summary: | Pass  Total
limits of @by |    2      2
Test Summary:                      | Pass  Total
@transform with grouped data frame |   12     12
        PASSED: grouping.jl
Test Summary: | Pass  Total
subset        |   17     17
Test Summary:      | Pass  Total
subset with :block |    5      5
Test Summary: | Pass  Total
subset!       |   18     18
Test Summary:       | Pass  Total
subset! with :block |    5      5
Test Summary:                     | Pass  Total
@subset with a grouped data frame |    3      3
Test Summary:                      | Pass  Total
@subset! with a grouped data frame |    3      3
        PASSED: subset.jl
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
Test Summary:        | Pass  Total
function_compilation |   56     56
        PASSED: function_compilation.jl
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
        PASSED: chaining.jl
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: @linq is deprecated. Use @chain instead. See ? @chain for details
│   caller = eval at boot.jl:360 [inlined]
└ @ Core ./boot.jl:360
Test Summary:     | Pass  Total
@linq with `cols` |    1      1
        PASSED: linqmacro.jl
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: Returning a Table object from @by and @combine now requires `cols(AsTable)` on the LHS.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1356
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
┌ Warning: `@based_on` is deprecated. Use `@combine` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:1347
Test Summary: | Pass  Total
@based_on     |   34     34
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
Test Summary: | Pass  Total
where         |   17     17
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
Test Summary:     | Pass  Total
where with :block |    5      5
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
Test Summary:                    | Pass  Total
@where with a grouped data frame |    3      3
Test Summary:           | Pass  Total
Unquoted symbols on LHS |   11     11
        PASSED: deprecated.jl
Test Summary:          | Pass  Total
@transform with @byrow |   11     11
Test Summary:           | Pass  Total
@transform! with @byrow |   11     11
Test Summary:       | Pass  Total
@select with @byrow |   11     11
Test Summary:        | Pass  Total
@select! with @byrow |   11     11
Test Summary:     | Pass  Total
@with with @byrow |    4      4
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
┌ Warning: `@where is deprecated, use `@subset` instead.
└ @ DataFramesMeta ~/.julia/dev/DataFramesMeta/src/macros.jl:586
Test Summary:     | Pass  Total
where with @byrow |    2      2
Test Summary:       | Pass  Total
orderby with @byrow |    2      2
Test Summary:        | Pass  Total
@combine with @byrow |   11     11
Test Summary:   | Pass  Total
@by with @byrow |   11     11
        PASSED: byrow.jl
WARNING: replacing module Testbyrow.
Test Summary:                 | Pass  Total
@transform with cols(AsTable) |    3      3
Test Summary:                 | Pass  Total
@select with cols(AsTable) =  |    3      3
Test Summary:                     | Pass  Total
@transform! with cols(AsTable) =  |    3      3
Test Summary:                  | Pass  Total
@select! with cols(AsTable) =  |    3      3
Test Summary:                  | Pass  Total
@combine with cols(AsTable) =  |    3      3
Test Summary:             | Pass  Total
@by with cols(AsTable) =  |    1      1
        PASSED: astable.jl
     Testing DataFramesMeta tests passed

@pdeffebach
Copy link
Collaborator

pdeffebach commented Jul 23, 2021

Indeed, thank you!

@etpinard
Copy link
Contributor Author

etpinard commented Jul 23, 2021

Thanks for the quick reply!

I've also noticed that @where is still mentioned in a few places in the docs:

 $ ag "@where" docs
docs/src/index.md
306:* `@subset`, `@subset!` and `@orderby`, with syntax of the form `@where(df, @byrow :x > :y)`
315:julia> @where df @byrow begin
449:    @where            filter           Where
473:    @where(:a .> 2)
491:    @where(:a .> 2)

I can push a commit that replaces these @where for @subset if you'd like.

@pdeffebach
Copy link
Collaborator

pdeffebach commented Jul 23, 2021

Sure, could you please make those replacements?

@pdeffebach pdeffebach merged commit 7b3b064 into JuliaData:master Jul 23, 2021
@pdeffebach
Copy link
Collaborator

pdeffebach commented Jul 23, 2021

Thanks!

@etpinard etpinard deleted the fix-where-macro-deprecation-warning branch July 23, 2021 19:33
@etpinard
Copy link
Contributor Author

etpinard commented Jul 23, 2021

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdeffebach pdeffebach pdeffebach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard @pdeffebach