Skip to content

NFC: test sum(iszero, xs) #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NFC: test sum(iszero, xs) #535

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae0a9fa
NFC: test sum(iszero, xs)
oxinabox Sep 24, 2021
ddff125
Merge branch 'main' into ox/testsumiszero
mcabbott Dec 2, 2021
beb416e
Merge branch 'main' into ox/testsumiszero
mcabbott May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/rulesets/Base/mapreduce.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,12 @@ const CFG = ChainRulesTestUtils.ADviaRuleConfig()
test_rrule(sum, sqrt, randn(5) .> 0)
test_rrule(sum, sqrt, randn(5,5) .> 0; fkwargs=(;dims=1))
# ... and Bool produced by function
# https://github.com/JuliaDiff/ChainRulesTestUtils.jl/issues/219
@test_skip test_rrule(sum, iszero, randn(5)) # DimensionMismatch("second dimension of A, 1, does not match length of x, 0")

_, pb = rrule(CFG, sum, iszero, randn(5))
@test pb(1.0) == (NoTangent(), NoTangent(), NoTangent(),)

# Functions that return a Vector
# see https://github.com/FluxML/Zygote.jl/issues/1074
test_rrule(sum, make_two_vec, [1.0, 3.0, 5.0, 7.0])
Expand Down