-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata overhaul #164
Merged
Merged
metadata overhaul #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hexaeder
commented
Oct 21, 2024
- add alias checks for components, copy if necessary so we don't shadow the metadata (fixes Check for identical references in vertex/edge list #160)
- mv metadata stuff into own file
- allow symbolic indexing based on the "name" of a component, if that name is unique (fixes allow symbolic indexing based on component name #147)
If components share the same metadata objects (for example because of `vertices = [v1, v1, v2]`), create copys to dealias! Also, for homogenous networks all components are copied on NW construction.
can be used to change single things about them, like the name for example
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
track the hashes of aliased vertex/edge functions, such that we can warn when they are changed. For large networks which do not use the meta data machinery this is much better then eagerly copying every component.
This comment has been minimized.
This comment has been minimized.
Benchmark Results
https://github.com/JuliaDynamics/NetworkDynamics.jl/actions/runs/11481996660/artifacts/2094127973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.