-
Notifications
You must be signed in to change notification settings - Fork 47
Objective-C Availability support #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/version.jl b/test/version.jl
index f72aef4a..d6722fbe 100644
--- a/test/version.jl
+++ b/test/version.jl
@@ -1,11 +1,11 @@
@testset "Version" begin
-@test Metal.darwin_version() isa VersionNumber
-@test Metal.macos_version() isa VersionNumber
-@test Metal.is_macos(Metal.macos_version())
+ @test Metal.darwin_version() isa VersionNumber
+ @test Metal.macos_version() isa VersionNumber
+ @test Metal.is_macos(Metal.macos_version())
-@test Metal.metallib_support() isa VersionNumber
-@test Metal.air_support() isa VersionNumber
-@test Metal.metal_support() isa VersionNumber
+ @test Metal.metallib_support() isa VersionNumber
+ @test Metal.air_support() isa VersionNumber
+ @test Metal.metal_support() isa VersionNumber
end # testset "Version" |
2563fba to
88a232a
Compare
13df448 to
4766e05
Compare
a648827 to
be3d848
Compare
be3d848 to
7409758
Compare
7409758 to
155e638
Compare
155e638 to
f6b5c75
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
+ Coverage 71.04% 76.32% +5.28%
==========================================
Files 36 57 +21
Lines 1143 2657 +1514
==========================================
+ Hits 812 2028 +1216
- Misses 331 629 +298 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metal Benchmarks
| Benchmark suite | Current: f6b5c75 | Previous: 991f6df | Ratio |
|---|---|---|---|
private array/construct |
24545.083333333336 ns |
24232.583333333336 ns |
1.01 |
private array/broadcast |
463770.5 ns |
459458 ns |
1.01 |
private array/random/randn/Float32 |
815542 ns |
923042 ns |
0.88 |
private array/random/randn!/Float32 |
637833.5 ns |
597958 ns |
1.07 |
private array/random/rand!/Int64 |
569833 ns |
555604.5 ns |
1.03 |
private array/random/rand!/Float32 |
605041 ns |
547834 ns |
1.10 |
private array/random/rand/Int64 |
770875 ns |
878687.5 ns |
0.88 |
private array/random/rand/Float32 |
624125 ns |
795125 ns |
0.78 |
private array/copyto!/gpu_to_gpu |
662854.5 ns |
545583.5 ns |
1.21 |
private array/copyto!/cpu_to_gpu |
693604 ns |
706125 ns |
0.98 |
private array/copyto!/gpu_to_cpu |
812458 ns |
611479 ns |
1.33 |
private array/accumulate/1d |
1357333.5 ns |
1426146 ns |
0.95 |
private array/accumulate/2d |
1398708 ns |
1483020.5 ns |
0.94 |
private array/iteration/findall/int |
2112917 ns |
2315500 ns |
0.91 |
private array/iteration/findall/bool |
1813187.5 ns |
2038792 ns |
0.89 |
private array/iteration/findfirst/int |
1713666.5 ns |
1783917 ns |
0.96 |
private array/iteration/findfirst/bool |
1677562.5 ns |
1725417 ns |
0.97 |
private array/iteration/scalar |
3671500 ns |
2600271 ns |
1.41 |
private array/iteration/logical |
3207417 ns |
3516646 ns |
0.91 |
private array/iteration/findmin/1d |
1767333 ns |
1891167 ns |
0.93 |
private array/iteration/findmin/2d |
1366270.5 ns |
1417833 ns |
0.96 |
private array/reductions/reduce/1d |
1058958 ns |
940416 ns |
1.13 |
private array/reductions/reduce/2d |
663708 ns |
700875.5 ns |
0.95 |
private array/reductions/mapreduce/1d |
1057583 ns |
947771 ns |
1.12 |
private array/reductions/mapreduce/2d |
669083 ns |
696333.5 ns |
0.96 |
private array/permutedims/4d |
2512625 ns |
2664166.5 ns |
0.94 |
private array/permutedims/2d |
1023792 ns |
1084396 ns |
0.94 |
private array/permutedims/3d |
1574208 ns |
1786604.5 ns |
0.88 |
private array/copy |
584687.5 ns |
813687.5 ns |
0.72 |
latency/precompile |
9187653208 ns |
9074494166 ns |
1.01 |
latency/ttfp |
3663724375 ns |
3656792125 ns |
1.00 |
latency/import |
1238943583 ns |
1254788541.5 ns |
0.99 |
integration/metaldevrt |
700354.5 ns |
748729 ns |
0.94 |
integration/byval/slices=1 |
1639625 ns |
1661625 ns |
0.99 |
integration/byval/slices=3 |
9376500 ns |
20205125 ns |
0.46 |
integration/byval/reference |
1515334 ns |
1671416.5 ns |
0.91 |
integration/byval/slices=2 |
2702750 ns |
2830312.5 ns |
0.95 |
kernel/indexing |
455167 ns |
463666 ns |
0.98 |
kernel/indexing_checked |
457895.5 ns |
470208.5 ns |
0.97 |
kernel/launch |
8083 ns |
9090.333333333334 ns |
0.89 |
metal/synchronization/stream |
14792 ns |
15083 ns |
0.98 |
metal/synchronization/context |
15250 ns |
15666 ns |
0.97 |
shared array/construct |
24370.8 ns |
24201.333333333332 ns |
1.01 |
shared array/broadcast |
464083 ns |
459542 ns |
1.01 |
shared array/random/randn/Float32 |
792583 ns |
913146 ns |
0.87 |
shared array/random/randn!/Float32 |
634834 ns |
595042 ns |
1.07 |
shared array/random/rand!/Int64 |
569750 ns |
554416 ns |
1.03 |
shared array/random/rand!/Float32 |
588667 ns |
559812.5 ns |
1.05 |
shared array/random/rand/Int64 |
759125 ns |
868708 ns |
0.87 |
shared array/random/rand/Float32 |
669687 ns |
853666 ns |
0.78 |
shared array/copyto!/gpu_to_gpu |
82312.5 ns |
83250 ns |
0.99 |
shared array/copyto!/cpu_to_gpu |
87541 ns |
79417 ns |
1.10 |
shared array/copyto!/gpu_to_cpu |
83687.5 ns |
79792 ns |
1.05 |
shared array/accumulate/1d |
1361209 ns |
1460583 ns |
0.93 |
shared array/accumulate/2d |
1400646 ns |
1494958 ns |
0.94 |
shared array/iteration/findall/int |
1814542 ns |
2019167 ns |
0.90 |
shared array/iteration/findall/bool |
1617541 ns |
1766791.5 ns |
0.92 |
shared array/iteration/findfirst/int |
1397583.5 ns |
1537479.5 ns |
0.91 |
shared array/iteration/findfirst/bool |
1371750 ns |
1438979.5 ns |
0.95 |
shared array/iteration/scalar |
160500 ns |
161042 ns |
1.00 |
shared array/iteration/logical |
2990291.5 ns |
3305854 ns |
0.90 |
shared array/iteration/findmin/1d |
1469833 ns |
1580417 ns |
0.93 |
shared array/iteration/findmin/2d |
1369084 ns |
1442375 ns |
0.95 |
shared array/reductions/reduce/1d |
734125 ns |
670708 ns |
1.09 |
shared array/reductions/reduce/2d |
672125 ns |
704292 ns |
0.95 |
shared array/reductions/mapreduce/1d |
752042 ns |
679437 ns |
1.11 |
shared array/reductions/mapreduce/2d |
671542 ns |
710833 ns |
0.94 |
shared array/permutedims/4d |
2538375 ns |
2629125 ns |
0.97 |
shared array/permutedims/2d |
1034499.5 ns |
1099583 ns |
0.94 |
shared array/permutedims/3d |
1585000 ns |
1797312.5 ns |
0.88 |
shared array/copy |
235542 ns |
209042 ns |
1.13 |
This comment was automatically generated by workflow using github-action-benchmark.
Good to go?