-
-
Notifications
You must be signed in to change notification settings - Fork 21
Test: prune old LA based on ENV variable #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
==========================================
- Coverage 93.74% 93.73% -0.01%
==========================================
Files 34 34
Lines 15752 15752
==========================================
- Hits 14766 14765 -1
- Misses 986 987 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 8b1e521.
I thought about disabling this only when we run on Julia buildkite so that |
This reverts commit 8f3ab76.
Anyway, at least for now, using an env variable here is better than not I think. But it would be good to perhaps have a blurb in the README of how to test linear algebra locally then? |
I think the current state of the PR should resolve the issue. I am able to build julia with the latest commit and run the test files directly. |
This PR prunes the old
LinearAlgebra
module based on an environment variable that is set in.ci/run_tests.jl
. Hopefully, this would mean that tests that are being run without this environment variable would run as expected without precompilation issues.The goal of this PR is to ensure that when julia is being built with the master branch of
LinearAlgebra
, the tests would work without the need for pruning (i.e., we want to fix the test failures in JuliaLang/julia#58242).This would also mean that to run the tests locally, one would need to set the
JULIA_PRUNE_OLD_LA
environment variable totrue
.