Skip to content

Clarify the structure of Bunch-Kaufman factors #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danielwe
Copy link
Contributor

@danielwe danielwe commented May 8, 2025

It took me a while to realize that the D in Bunch-Kaufman is block diagonal, not diagonal, so I thought I'd save others the trouble. I also mention P, U, and L for completeness, even though they are less surprising since they match the usual meaning of matrix factors with those names.

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (7f354f4) to head (260cbf2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   93.75%   93.77%   +0.02%     
==========================================
  Files          34       34              
  Lines       15778    15778              
==========================================
+ Hits        14792    14796       +4     
+ Misses        986      982       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Daniel Karrasch <[email protected]>
@ViralBShah
Copy link
Member

@danielwe - Invited you to have commit access.

@danielwe
Copy link
Contributor Author

danielwe commented May 9, 2025

Was that meant for @araujoms in #1340? I don't see an invitation, and although I appreciate any recognition of my small contributions here and there, I'm not sure I should qualify for commit access

@ViralBShah
Copy link
Member

I already sent it to @araujoms. And happy to have more help with triaging and small things. For now, I won't retrigger it though - but please let me know if you'd find it valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants