Skip to content

release-1.6: fix a regression in Pkg before 1.6.3 is released #42282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KristofferC merged 1 commit into from
Sep 20, 2021
Merged

release-1.6: fix a regression in Pkg before 1.6.3 is released #42282

KristofferC merged 1 commit into from
Sep 20, 2021

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Sep 16, 2021

Adds JuliaLang/Pkg.jl#2730 to Pkg which is a revert of a commit that had some issues.

@KristofferC KristofferC added the release Release management and versioning. label Sep 16, 2021
Sacha0
Sacha0 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific, thanks Kristoffer! :)

@Sacha0 Sacha0 mentioned this pull request Sep 16, 2021
Merged
@Sacha0
Copy link
Member

Sacha0 commented Sep 16, 2021

Looking at the tester_linux64 log I found this:

channels                           (4) |         failed at 2021-09-16T22:14:30.676
Test Failed at /buildworker/worker/tester_linux64/build/share/julia/test/channels.jl:297
  Expression: ���(duration, 1, atol = 0.4)
   Evaluated: 1.899859072 ��� 1 (atol=0.4)
Test Failed at /buildworker/worker/tester_linux64/build/share/julia/test/channels.jl:429
  Expression: tc[] == 2
   Evaluated: 1 == 2
Test Failed at /buildworker/worker/tester_linux64/build/share/julia/test/channels.jl:431
  Expression: tc[] == 2
   Evaluated: 1 == 2
Test Failed at /buildworker/worker/tester_linux64/build/share/julia/test/channels.jl:438
  Expression: tc[] == 2
   Evaluated: 1 == 2
Test Failed at /buildworker/worker/tester_linux64/build/share/julia/test/channels.jl:439
  Expression: tc[] == 2
   Evaluated: 1 == 2
Test Failed at /buildworker/worker/tester_linux64/build/share/julia/test/channels.jl:441
  Expression: tc[] == 3
   Evaluated: 2 == 3
Test Failed at /buildworker/worker/tester_linux64/build/share/julia/test/channels.jl:443
  Expression: tc[] == 3
   Evaluated: 2 == 3

which appears unrelated but is worrisome. Is that failure mode known?

Later the job timed out, not sure why.

Restarting as neither of those failure modes appear related to this diff :).

@Sacha0
Copy link
Member

Sacha0 commented Sep 17, 2021

tester_linux32 seems happy now, so 🙈 🎉 I guess? 😄 (Should we separately file the channels failure?)

@DilumAluthge
Copy link
Member

DilumAluthge commented Sep 17, 2021

The buildbot/tester_macos64 job did not run, for some reason.

@DilumAluthge
Copy link
Member

DilumAluthge commented Sep 17, 2021

Nor did the buildbot/package_macos64 job.

@DilumAluthge DilumAluthge reopened this Sep 17, 2021
@DilumAluthge DilumAluthge reopened this Sep 17, 2021
@Sacha0
Copy link
Member

Sacha0 commented Sep 17, 2021

Closing/opening this pull request doesn't seem to be doing the trick with regard to buildbot/tester_macos64 and buildbot/package_macos64. Is there some other way we can nudge those? :)

@DilumAluthge
Copy link
Member

DilumAluthge commented Sep 17, 2021

For those following along in this thread, we are working on fixing the macOS Buildbots. Join the #infrastructure channel on Slack for more details.

@DilumAluthge DilumAluthge reopened this Sep 17, 2021
@DilumAluthge
Copy link
Member

DilumAluthge commented Sep 17, 2021

Okay, the macOS packager has passed. Let's make sure the macOS tester passes.

@DilumAluthge DilumAluthge reopened this Sep 18, 2021
@Sacha0
Copy link
Member

Sacha0 commented Sep 18, 2021

The buildbot/package_linuxppc64le failures appear unrelated:

 ==> ./julia launch speedtest
make: time: Command not found
make: *** [build-stats] Error 127
program finished with exit code 2
elapsedTime=2.389282

and

  Installing known registries into `/buildworker/worker/package_linuxppc64le/build/doc/deps`
ERROR: LoadError: expected package `Parsers [69de0a69]` to be registered
Stacktrace:
 [1] pkgerror(msg::String)
   @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:55
 [2] check_registered(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec})
   @ Pkg.Operations /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Operations.jl:1157
 [3] instantiate(ctx::Pkg.Types.Context; manifest::Nothing, update_registry::Bool, verbose::Bool, platform::Base.BinaryPlatforms.Platform, allow_build::Bool, allow_autoprecomp::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Pkg.API /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1372
 [4] instantiate
   @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1325 [inlined]
 [5] #instantiate#252
   @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1321 [inlined]
 [6] instantiate()
   @ Pkg.API /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1321
 [7] top-level scope
   @ /buildworker/worker/package_linuxppc64le/build/doc/make.jl:8
in expression starting at /buildworker/worker/package_linuxppc64le/build/doc/make.jl:8
caused by: could not download https://pkg.julialang.org/registry/23338594-aafe-5451-b93e-139f81909106/cc9d45ece542806aa9bc5da7c2bca2f15849a763
Stacktrace:
  [1] pkgerror(msg::String)
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:55
  [2] (::Pkg.Types.var"#82#85"{Pkg.Types.Context, String, Pkg.Types.RegistrySpec})(tmp::String)
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1035
  [3] mktempdir(fn::Pkg.Types.var"#82#85"{Pkg.Types.Context, String, Pkg.Types.RegistrySpec}, parent::String; prefix::String)
    @ Base.Filesystem ./file.jl:729
  [4] mktempdir (repeats 2 times)
    @ ./file.jl:727 [inlined]
  [5] clone_or_cp_registries(ctx::Pkg.Types.Context, regs::Vector{Pkg.Types.RegistrySpec}, depot::String)
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1027
  [6] clone_or_cp_registries
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1020 [inlined]
  [7] clone_default_registries(ctx::Pkg.Types.Context; only_if_empty::Bool)
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:920
  [8] clone_default_registries
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:908 [inlined]
  [9] find_registered!(ctx::Pkg.Types.Context, names::Vector{String}, uuids::Vector{Base.UUID})
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1291
 [10] find_registered!
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1252 [inlined]
 [11] check_registered(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec})
    @ Pkg.Operations /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Operations.jl:1154
 [12] instantiate(ctx::Pkg.Types.Context; manifest::Nothing, update_registry::Bool, verbose::Bool, platform::Base.BinaryPlatforms.Platform, allow_build::Bool, allow_autoprecomp::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ Pkg.API /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1366
 [13] instantiate
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1325 [inlined]
 [14] #instantiate#252
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1321 [inlined]
 [15] instantiate()
    @ Pkg.API /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1321
 [16] top-level scope
    @ /buildworker/worker/package_linuxppc64le/build/doc/make.jl:8
caused by: HTTP/2 502 while requesting https://pkg.julialang.org/registry/23338594-aafe-5451-b93e-139f81909106/cc9d45ece542806aa9bc5da7c2bca2f15849a763
Stacktrace:
  [1] (::Downloads.var"#3#4"{Nothing, Vector{Pair{String, String}}, Float64, Pkg.PlatformEngines.var"#14#16", Bool, Nothing, String})(output::IOStream)
    @ Downloads /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Downloads/src/Downloads.jl:233
  [2] open(f::Downloads.var"#3#4"{Nothing, Vector{Pair{String, String}}, Float64, Pkg.PlatformEngines.var"#14#16", Bool, Nothing, String}, args::String; kwargs::Base.Iterators.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:write,), Tuple{Bool}}})
    @ Base ./io.jl:330
  [3] arg_write(f::Function, arg::String)
    @ ArgTools /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/ArgTools/src/ArgTools.jl:86
  [4] #download#2
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Downloads/src/Downloads.jl:221 [inlined]
  [5] download(url::String, dest::String; verbose::Bool, headers::Vector{Pair{String, String}}, auth_header::Nothing, io::IOContext{Base.PipeEndpoint})
    @ Pkg.PlatformEngines /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/PlatformEngines.jl:270
  [6] download_verify(url::String, hash::Nothing, dest::String; verbose::Bool, force::Bool, quiet_download::Bool)
    @ Pkg.PlatformEngines /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/PlatformEngines.jl:333
  [7] download_verify_unpack(url::String, hash::Nothing, dest::String; tarball_path::Nothing, ignore_existence::Bool, force::Bool, verbose::Bool, quiet_download::Bool, io::IOContext{Base.PipeEndpoint})
    @ Pkg.PlatformEngines /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/PlatformEngines.jl:488
  [8] (::Pkg.Types.var"#82#85"{Pkg.Types.Context, String, Pkg.Types.RegistrySpec})(tmp::String)
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1033
  [9] mktempdir(fn::Pkg.Types.var"#82#85"{Pkg.Types.Context, String, Pkg.Types.RegistrySpec}, parent::String; prefix::String)
    @ Base.Filesystem ./file.jl:729
 [10] mktempdir (repeats 2 times)
    @ ./file.jl:727 [inlined]
 [11] clone_or_cp_registries(ctx::Pkg.Types.Context, regs::Vector{Pkg.Types.RegistrySpec}, depot::String)
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1027
 [12] clone_or_cp_registries
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1020 [inlined]
 [13] clone_default_registries(ctx::Pkg.Types.Context; only_if_empty::Bool)
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:920
 [14] clone_default_registries
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:908 [inlined]
 [15] find_registered!(ctx::Pkg.Types.Context, names::Vector{String}, uuids::Vector{Base.UUID})
    @ Pkg.Types /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1291
 [16] find_registered!
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:1252 [inlined]
 [17] check_registered(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec})
    @ Pkg.Operations /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/Operations.jl:1154
 [18] instantiate(ctx::Pkg.Types.Context; manifest::Nothing, update_registry::Bool, verbose::Bool, platform::Base.BinaryPlatforms.Platform, allow_build::Bool, allow_autoprecomp::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ Pkg.API /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1366
 [19] instantiate
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1325 [inlined]
 [20] #instantiate#252
    @ /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1321 [inlined]
 [21] instantiate()
    @ Pkg.API /buildworker/worker/package_linuxppc64le/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1321
 [22] top-level scope
    @ /buildworker/worker/package_linuxppc64le/build/doc/make.jl:8
make[3]: *** [html] Error 1
make[3]: Leaving directory `/buildworker/worker/package_linuxppc64le/build/doc'
make[2]: *** [docs] Error 2
make[2]: Leaving directory `/buildworker/worker/package_linuxppc64le/build'
make[1]: *** [/buildworker/worker/package_linuxppc64le/build/doc/_build/html/en/index.html] Error 2
make[1]: Leaving directory `/buildworker/worker/package_linuxppc64le/build'
make: *** [binary-dist] Error 2
program finished with exit code 2
elapsedTime=12.548407

@KristofferC KristofferC merged commit 61565d6 into release-1.6 Sep 20, 2021
@KristofferC KristofferC deleted the backports-release-1.6.3 branch September 20, 2021 14:54
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@KristofferC @staticfloat
update Pkg to newest 1.6 version (#42282)
cd9ebb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Sacha0 Sacha0 Sacha0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release Release management and versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KristofferC @Sacha0 @DilumAluthge