Skip to content

Conversation

@DilumAluthge
Copy link
Member

Follow-up to #47707

@DilumAluthge DilumAluthge added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Dec 1, 2022
@DilumAluthge DilumAluthge requested a review from maleadt December 1, 2022 01:07
@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Dec 1, 2022
@maleadt
Copy link
Member

maleadt commented Dec 1, 2022

Oh oops. How did you update those? I just ran make -f contrib/refresh_checksums.mk libuv.

@giordano
Copy link
Member

giordano commented Dec 1, 2022

How did you update those? I just ran make -f contrib/refresh_checksums.mk libuv.

But did you after #47707 (comment)? The fact that those checksums didn't change was how I noticed you hadn't updated the source.

@DilumAluthge
Copy link
Member Author

BTW in the future we'll catch this with JuliaCI/julia-buildkite#264

@maleadt
Copy link
Member

maleadt commented Dec 1, 2022

But did you after #47707 (comment)?

Ah no, that was my mistake. TIL, thanks.

@maleadt maleadt merged commit 293ab47 into master Dec 1, 2022
@maleadt maleadt deleted the dpa/libuv-checksums branch December 1, 2022 16:48
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Dec 5, 2022
@DilumAluthge DilumAluthge added the backport 1.9 Change should be backported to release-1.9 label Dec 29, 2022
KristofferC pushed a commit that referenced this pull request Jan 2, 2023
(cherry picked from commit 293ab47)
@KristofferC KristofferC mentioned this pull request Jan 2, 2023
41 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external dependencies Involves LLVM, OpenBLAS, or other linked libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants