aot: move jl_insert_backedges to Julia side
#56499
Open
+316
−371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/move-staticdata_utils-julia
branch
from
4959411
to
2eafa61
Compare
|
Does this have any performance diff? |
|
Moving the implementation to Julia seems to result in a slight increase in allocations, but considering the potential for future improvements, it doesn’t seem like a significant issue julia> @time using Debugger
0.287086 seconds (63.56 k allocations: 3.548 MiB) # master
0.280408 seconds (67.28 k allocations: 4.210 MiB) # this PR |
With #56447, the dependency between `jl_insert_backedges` and method insertion has been eliminated, allowing `jl_insert_backedges` to be performed after loading. As a result, it is now possible to move `jl_insert_backedges` to the Julia side. Currently this commit simply moves the implementation without adding any new features.
aviatesk
force-pushed
the
avi/move-staticdata_utils-julia
branch
from
2eafa61
to
718aea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #56447, the dependency between
jl_insert_backedgesand method insertion has been eliminated, allowingjl_insert_backedgesto be performed after loading. As a result, it is now possible to movejl_insert_backedgesto the Julia side.Currently this commit simply moves the implementation without adding any new features.