Generalize signature of checkbounds(A, I...)
#56502
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method checks if indices are within bounds, and throws an error if they aren't. Custom types such as
Broadcasted
, therefore, would only need to implement the bounds-checking logic, and may leave the error-throwing bit toBase
. They may do this by specializingcheckbounds(Bool, A::MyType, I...)
instead ofcheckbounds(A, I...)
, and the fallback implementation of the latter would handle processing the result.