Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34350, for a "wide" ("underdetermined") system of equations,
A \ b
seems to be more efficient if computed by "LQ" factorization, i.e. QR factorization of the transposeA'
. (More than 2x faster on my machine for a 100×1000 matrix.)lq(A)
, it does not currently support row-pivoting, so I useqr(A', ColumnNorm())'
instead, which is logically equivalent.Hopefully this is already covered by the existing tests?