-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
WIP: Read the terminal colour scheme on REPL startup #59958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5633335 to
7e22584
Compare
7e22584 to
c89eef3
Compare
80b448e to
0c05f5b
Compare
Any issue that we can file upstream? This is a fairly common configuration, esp. since iTerm2 has tmux integration |
Potentially, there seem to be a few closed OSC-related issues on tmux's repo. I'm also not 100% on the performance: it might be passing through fg/bg info, in which case as of some recent (unpushed) improvements we will still be able to set pick light/dark appropriately and set fg/bg colours. Testing tmux locally myself, I see that it does pass through OSC 10 and OSC 11 codes (these are the fg/bg codes): |
|
I'm not sure what's a good idea to do here in terms of unit testing, since this should be tested against a collection of different terminal emulators. |
Yes please! |
0c05f5b to
9869f0c
Compare
|
I now plan on getting this merged after #60527, and have adjusted the PR accordingly. |
Wouldn't it be nice if Julia/the REPL knew what your terminal colours were, and displayed content appropriately?
useful description coming soon-ish
Sneak peek:
Query durations
Important
This is asynchronous, and does not impact startup latency
Tested terminals
Test script
Everything works
Misbehaving (terminal's fault)
Misbehaving (our fault)
This is not ready for review yet, I just want CI to build it so that helpful testers on Zulip (:wave:) can try this with
juliaup add +pr59958.