-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
[release-1.11] Fix KeyError in require_stdlib for non-stdlib extensions #60491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.11] Fix KeyError in require_stdlib for non-stdlib extensions #60491
Conversation
When require_stdlib is called with an extension and the 'from' module is not from the bundled depot (from_stdlib=false), start_loading was not called but end_loading was still called in the finally block, causing a KeyError when trying to pop from package_locks. Track whether start_loading was called and only call end_loading when appropriate. Fixes JuliaLang#60392 Co-authored-by: Claude <[email protected]>
|
@DilumAluthge @KristofferC I believe this is relatively urgent? |
|
I've recreated the |
|
@vtjnash Would you be able to review this? |
|
I tested this PR locally, and at least for me it seems to fix the issue reported in #60392. On Julia 1.11.8 (with Using this PR: |
vtjnash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
deb1167
into
JuliaLang:backports-release-1.11
When require_stdlib is called with an extension and the 'from' module is not from the bundled depot (from_stdlib=false), start_loading was not called but end_loading was still called in the finally block, causing a KeyError when trying to pop from package_locks.
Track whether start_loading was called and only call end_loading when appropriate.
Fixes #60392
Reproducer (test added):