Prevent downgrading on old version in mirror#889
Prevent downgrading on old version in mirror#889ghyatzo wants to merge 5 commits intoJuliaLang:mainfrom
Conversation
davidanthoff
left a comment
There was a problem hiding this comment.
I think this would also disable the ability to switch from a prerelease channel to the release channel, where we want a downgrade to happen. So I don't think we can merge this as is...
|
I completely missed that possibility, sorry. I have ready an incomplete patch for it, but there is another issue. What should be the default behaviour when the self update is run non interactlively. Should we default to not downgrade at all? Or install whatever it is found on the channel? I'd be more towards ignoring any downgrades, to avoid surprises. for now an example of interaction is the following: Other possible behaviour to consider: if the version is the same, just update normally. EDIT: I'll push the changes made, with the caveat that they are still incomplete and need the non-interactive scenario to be addressed. |
|
I just opted for pushing a complete working version, so that if you agree it's ready. Namely:
|
f5f37f4 to
c62d3e0
Compare
c62d3e0 to
cfc4214
Compare
cfc4214 to
9bbaf96
Compare
|
This PR has not been updated in over one year. @ghyatzo Are you still interested in working on this PR? |
|
The PR was ready for review at the time. I can rebase this on master and see where it goes from there |
|
Yeah, that would be great. Once you've rebased, let me know, and I can try to find a reviewer. |
…ror is lower than the current one.
…hing back from a preview version to the release version.
9bbaf96 to
915147e
Compare
|
@IanButterworth or @davidanthoff - Could you re-review this, and see if the previously requested changes have been made? |
fix: reinstalling same version is not counted as downgrading.
915147e to
559463a
Compare
should fix #250