WIP: Use dense LAPACK routines via block-tridiagonal view for banded * and qr#159
Open
dlfivefifty wants to merge 3 commits intomasterfrom
Open
WIP: Use dense LAPACK routines via block-tridiagonal view for banded * and qr#159dlfivefifty wants to merge 3 commits intomasterfrom
dlfivefifty wants to merge 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 72.77% 71.60% -1.17%
==========================================
Files 21 22 +1
Lines 2516 2557 +41
==========================================
Hits 1831 1831
- Misses 685 726 +41
Continue to review full report at Codecov.
|
Member
|
What's needed for this to merge? Just more tests? |
Member
Author
|
It hasn't been done yet, it's just a bunch of experiments at the moment. I got disheartened when I realized LAPACK's For banded * banded, the issue is that there is apparently no BLAS triangular * triangular. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make QR and banded * banded operations much faster by leveraging fast dense linear algebra for blocks