Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FirstMatchLogger #24

Closed
wants to merge 1 commit into from
Closed

Add FirstMatchLogger #24

wants to merge 1 commit into from

Conversation

tkf
Copy link

@tkf tkf commented Oct 25, 2019

close #23

@tkf tkf mentioned this pull request Oct 25, 2019
Open
@codecov-io
Copy link

codecov-io commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #24 into master will increase coverage by 1.69%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   78.94%   80.64%   +1.69%     
==========================================
  Files           7        7              
  Lines          57       62       +5     
==========================================
+ Hits           45       50       +5     
  Misses         12       12
Impacted Files Coverage Δ
src/LoggingExtras.jl 100% <ø> (ø) ⬆️
src/tee.jl 92.3% <100%> (+4.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d4071...75e512c. Read the comment docs.

tkf
tkf commented Oct 25, 2019
View reviewed changes
src/tee.jl
@@ -26,14 +28,38 @@ function handle_message(demux::TeeLogger, args...; kwargs...)
end
end

function shouldlog(demux::TeeLogger, args...)
function shouldlog(demux::AbstractTeeLogger, args...)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldlog, min_enabled_level, and catch_exceptions for FirstMatchLogger are all identical to TeeLogger so I created an abstract type. Is it OK?

@tkf
Copy link
Author

tkf commented Oct 25, 2019

Closing due to #23 (comment).

@tkf tkf closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make handle_message return true/false depending on if accepted
2 participants
@tkf @codecov-io