Skip non-file entries when scanning for event files (fixes #152) - #153
Open
CarloLucibello wants to merge 1 commit into
Open
Skip non-file entries when scanning for event files (fixes #152)#153CarloLucibello wants to merge 1 commit into
CarloLucibello wants to merge 1 commit into
Conversation
`TBEventFileCollectionIterator` opened every entry returned by `readdir`, including subdirectories. Opening a directory throws "Permission denied" on Windows, crashing `map_summaries`/log reading whenever a sibling folder (e.g. `checkpoints/`) coexists with the event files. Guard the `open` call with `isfile` so subdirectories are skipped on all platforms. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152.
TBEventFileCollectionIteratoropened every entry returned byreaddir, including subdirectories. Opening a directory throws a "Permission denied" error on Windows, which crashesmap_summaries/ log reading whenever a sibling folder (e.g. acheckpoints/directory) coexists with the event files in the log directory. On Linux/macOSopenon a directory happens to succeed, masking the problem.This adds an
isfileguard before theopencall so subdirectories and other non-file entries are skipped consistently across platforms.A subdirectory is now created in the deserialization test to cover the scenario.
🤖 Generated with Claude Code