make isprime(::BigInt) use deterministic algo when possible #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oscardssmith I have a hard time finding time to follow the recent discussions in this repo, I see you have multiple open PRs, which one would you like to be reviewed first? And I totally forgot about this open PR you closed here, is it not valid anymore, or is it superseded by another PR? |
|
I probably should have left a message before closing this, but TLDR is that GMP does this for us. From my brief benchmarking, just calling to GMP is about the same speed as converting first. Can you review #102 first? It's relatively simple, but a massive speedup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
BigIntis small enough (n<=2^64currently), I don't see why it shouldn't use the deterministic algorithm, in particular as it is usually not much slower (and can be faster sometimes).I also convert signed types to unsigned as it seems to be usually faster (but I tested only on 1 machine!)