Switch Requires.jl to weakdep#88
Conversation
oscardssmith
commented
May 5, 2025
DilumAluthge
left a comment
There was a problem hiding this comment.
Looks like Windows CI is failing?
| SpecialFunctions = "2.0" | ||
| Test = "<0.0.1, 1" | ||
| julia = "1.6" | ||
| julia = "1.10" |
There was a problem hiding this comment.
Is this change (dropping support for Julia 1.6 through 1.9) intentional?
There was a problem hiding this comment.
yes (but I can make this work on older versions if desired)
There was a problem hiding this comment.
I think we can just do #88 (comment), and thus not need to drop support for Julia 1.6 through 1.9 (but we still get the benefit of getting rid of Requires.jl).
|
Actually, I don't even think we need to drop support for Julia 1.6 through 1.9. Instead, we can do the following:
Basically, following the instructions in the "Transition from normal dependency to extension" section here: https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension |
|
And then, since we aren't dropping support for any old Julia versions, we can just do the patch version bump of |
|
Either way, we do need to fix Windows CI on this PR. |
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
|
@oscardssmith Do you have an idea as to why Windows CI is failing on this PR? I just checked, and all CI is green on |
|
I have no idea. Pkg extensions really shouldn't be OS specific, so while I agree that this PR causes the failures, I haven't the faintest idea why. |
|
Cody helped me figure out the problem. The issue was that this package made it's own fake |
|
So is this good to merge? (or do we want to do the version with Requires to allow backward compat to 1.6?) |
|
How about we do #88 (comment)? (Which doesn't use Requires.jl). |
|
changes made |
|
CI failures will be fixed by #91. |
Fix the formatting of the `Project.toml` file