Skip to content

Switch Requires.jl to weakdep - #88

Merged
oscardssmith merged 7 commits into
masterfrom
os/weakdep
May 13, 2025
Merged

oscardssmith merged 7 commits into
masterfrom
os/weakdep

Conversation

@oscardssmith

Copy link
Copy Markdown
Member
julia> @time using Quadmath
  0.009195 seconds (8.15 k allocations: 549.961 KiB, 34.84% compilation time) # before
  0.006442 seconds (4.01 k allocations: 305.828 KiB) #after

@oscardssmith
oscardssmith requested a review from DilumAluthge May 5, 2025 17:21

@DilumAluthge DilumAluthge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Windows CI is failing?

Comment thread Project.toml Outdated
SpecialFunctions = "2.0"
Test = "<0.0.1, 1"
julia = "1.6"
julia = "1.10"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change (dropping support for Julia 1.6 through 1.9) intentional?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes (but I can make this work on older versions if desired)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just do #88 (comment), and thus not need to drop support for Julia 1.6 through 1.9 (but we still get the benefit of getting rid of Requires.jl).

Comment thread Project.toml
@DilumAluthge DilumAluthge changed the title Switch Requires.jl to weakdep Switch Requires.jl to weakdep, and require Julia 1.10+ (thus dropping support for Julia 1.6 through 1.9) May 7, 2025
Comment thread Project.toml
@DilumAluthge

Copy link
Copy Markdown
Member

Actually, I don't even think we need to drop support for Julia 1.6 through 1.9. Instead, we can do the following:

  1. On Julia versions 1.6 through 1.9, make SpecialFunctions a regular direct dep.
  2. On Julia 1.10+, make SpecialFunctions a weakdep.

Basically, following the instructions in the "Transition from normal dependency to extension" section here: https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension

@DilumAluthge

Copy link
Copy Markdown
Member

And then, since we aren't dropping support for any old Julia versions, we can just do the patch version bump of 0.5.13 ---> 0.5.14.

@DilumAluthge

Copy link
Copy Markdown
Member

Either way, we do need to fix Windows CI on this PR.

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@DilumAluthge

Copy link
Copy Markdown
Member

@oscardssmith Do you have an idea as to why Windows CI is failing on this PR?

I just checked, and all CI is green on master (see e.g. #90), so the CI failure does seem related to the contents of this PR.

@oscardssmith

Copy link
Copy Markdown
Member Author

I have no idea. Pkg extensions really shouldn't be OS specific, so while I agree that this PR causes the failures, I haven't the faintest idea why.

@oscardssmith

Copy link
Copy Markdown
Member Author

Cody helped me figure out the problem. The issue was that this package made it's own fake @ccall that we weren't importing. I've renamed it to make this slightly less horrible (but I would like to delete this macro entirely)

@oscardssmith

Copy link
Copy Markdown
Member Author

So is this good to merge? (or do we want to do the version with Requires to allow backward compat to 1.6?)

@DilumAluthge

Copy link
Copy Markdown
Member

How about we do #88 (comment)? (Which doesn't use Requires.jl).

@oscardssmith

Copy link
Copy Markdown
Member Author

changes made

@DilumAluthge DilumAluthge changed the title Switch Requires.jl to weakdep, and require Julia 1.10+ (thus dropping support for Julia 1.6 through 1.9) Switch Requires.jl to weakdep May 13, 2025
@DilumAluthge
DilumAluthge self-requested a review May 13, 2025 20:03
@DilumAluthge

Copy link
Copy Markdown
Member

CI failures will be fixed by #91.

Fix the formatting of the `Project.toml` file
@oscardssmith
oscardssmith merged commit f6ea87e into master May 13, 2025
@oscardssmith
oscardssmith deleted the os/weakdep branch May 13, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants