-
Notifications
You must be signed in to change notification settings - Fork 13
Switch Requires.jl to weakdep #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oscardssmith
commented
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Windows CI is failing?
Project.toml
Outdated
SpecialFunctions = "2.0" | ||
Test = "<0.0.1, 1" | ||
julia = "1.6" | ||
julia = "1.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change (dropping support for Julia 1.6 through 1.9) intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes (but I can make this work on older versions if desired)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just do #88 (comment), and thus not need to drop support for Julia 1.6 through 1.9 (but we still get the benefit of getting rid of Requires.jl).
Actually, I don't even think we need to drop support for Julia 1.6 through 1.9. Instead, we can do the following:
Basically, following the instructions in the "Transition from normal dependency to extension" section here: https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension |
And then, since we aren't dropping support for any old Julia versions, we can just do the patch version bump of |
Either way, we do need to fix Windows CI on this PR. |
Co-authored-by: Dilum Aluthge <[email protected]>
@oscardssmith Do you have an idea as to why Windows CI is failing on this PR? I just checked, and all CI is green on |
I have no idea. Pkg extensions really shouldn't be OS specific, so while I agree that this PR causes the failures, I haven't the faintest idea why. |
Cody helped me figure out the problem. The issue was that this package made it's own fake |
So is this good to merge? (or do we want to do the version with Requires to allow backward compat to 1.6?) |
How about we do #88 (comment)? (Which doesn't use Requires.jl). |
changes made |
CI failures will be fixed by #91. |
Fix the formatting of the `Project.toml` file