Add more ChainRules derivatives #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 92.23% 92.33% +0.09%
==========================================
Files 12 12
Lines 2717 2725 +8
==========================================
+ Hits 2506 2516 +10
+ Misses 211 209 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stevengj
approved these changes
Sep 23, 2021
stevengj
reviewed
Sep 23, 2021
stevengj
reviewed
Sep 24, 2021
|
Maybe it's time for a new release (possibly after merging the fixes in #347)? The version number is already updated on the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds and tests derivatives for
airyaixairyaiprimexlogerfclogerfcxerf(x, y)besselkxhankelh1xhankelh2xIt also replaces irrationals in derivatives with constants from IrrationalConstants. This fixes #307.