-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases, disable flatness check in HZ #180
Draft
timholy
wants to merge
9
commits into
master
Choose a base branch
from
teh/flatness
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ba7217c - Browse repository at this point
Copy the full SHA ba7217cView commit details -
Add an attempted flatness-convergence test
The flatness check in HagerZhang was intended to prevent excessive iteration in cases where the objective function is flat to within numerical precision. This test is a poor attempt at capturing the issue. HZ takes more iterations than any other linesearch algorithm, but it's still a far cry from real-world cases I've seen where the linesearch exits from the iteration limit.
Configuration menu - View commit details
-
Copy full SHA for 71b72e1 - Browse repository at this point
Copy the full SHA 71b72e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c043db6 - Browse repository at this point
Copy the full SHA c043db6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c98734 - Browse repository at this point
Copy the full SHA 2c98734View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5043bb - Browse repository at this point
Copy the full SHA c5043bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a278334 - Browse repository at this point
Copy the full SHA a278334View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15be1b1 - Browse repository at this point
Copy the full SHA 15be1b1View commit details
Commits on Oct 24, 2024
-
This follows the notation in the paper and is much more readable. It also introduces an external parameter, `epsilonk`, that "solves" the flatness problem (though it requires external specification).
Configuration menu - View commit details
-
Copy full SHA for 875b2ca - Browse repository at this point
Copy the full SHA 875b2caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92c46a6 - Browse repository at this point
Copy the full SHA 92c46a6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.