Start in interior of variable bounds #1073
Open
+39
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 85.46% 85.75% +0.29%
==========================================
Files 45 46 +1
Lines 3274 3511 +237
==========================================
+ Hits 2798 3011 +213
- Misses 476 500 +24 ☔ View full report in Codecov by Sentry. |
|
I suggesting investigating the remaining failing tests in separate PRs |
|
@pkofod This PR is good to go from my end |
thanks I will look. Busy feb and march for me 😓 |
blegat
force-pushed
the
bl/feasible_start
branch
from
c43736e
to
1d9aabb
Compare
|
Thanks, I just rebased to fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in #1071, most tests were failing because the starting point was infeasible.
With this PR, most are now passing.
The remaining ones to investigate are:
test_nonlinear_expression_hs071: this one gives an infeasible solution, not sure if it's due to the fact that the starting values does not satisfy the constraints, no warning is thrown though.test_nonlinear_expression_hs071_epigraph: the variables are in the interior of the bounds but some of the constraints are not satisfied hence the warning is thrown. Then it converges to an incorrect solutiontest_objective_FEASIBILITY_SENSE_clears_objective: this one seems it may be a bug in the MOI wrapper, let me investigate first