add libimagequant #10853
Merged
add libimagequant #10853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Mar 29, 2025
giordano
reviewed
Mar 29, 2025
Co-authored-by: Mosè Giordano <[email protected]>
ericphanson
commented
Mar 29, 2025
Contributor
Author
|
ran out of space on one: on another, which seems like it has come up before: |
Member
|
Contributor
Author
|
I got the wrapper working at least :) https://github.com/ericphanson/LibImageQuant.jl |
Contributor
Author
|
somehow buildkite did not use the latest commit from my PR :/ https://buildkite.com/julialang/yggdrasil/builds/19292#019612b6-16a3-4420-adf6-ca57ed06dc02/689-841 but that line isn't in da58b41, the commit the CI is running on... |
Contributor
Author
|
ok! this is finally working. Good to go from my side. |
giordano
reviewed
Nov 29, 2025
L/libimagequant/build_tarballs.jl
Outdated
|
|
||
| # Dependencies that must be installed before this package can be built | ||
| dependencies = [ | ||
| BuildDependency("OpenSSL_jll"), |
Member
There was a problem hiding this comment.
Why is this a build-only dependency?
Contributor
Author
There was a problem hiding this comment.
oops, neither. I think it was a cargo-c dep but I'm not using that anymore. Removed
Co-authored-by: Mosè Giordano <[email protected]>
giordano
reviewed
Nov 29, 2025
Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure I got it right