Skip to content

Fix some JET warnings regarding matching methods for strip(...) and parse(...) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DilumAluthge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some JET warnings regarding matching methods for strip(...) and parse(...) #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/slurmmanager.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,12 @@ function Distributed.launch(manager::SlurmManager, params::Dict, instances_arr::
line = readline(manager.srun_proc)
m = match(r".*:(\d*)#(.*)", line)
m === nothing && error("could not parse $line")
m[1] === nothing && error("could not extract port (m[1]) after parsing $line")
m[2] === nothing && error("could not extract host (m[2]) after parsing $line")

config = WorkerConfig()
config.port = parse(Int, m[1])
config.host = strip(m[2])
config.port = parse(Int, m[1]::AbstractString)
config.host = strip(m[2]::AbstractString)

@debug "Worker $i ready on host $(config.host), port $(config.port)"

Expand Down