Branch for testing DemoCards.jl #256

BeastyBlacksmith · 2021-08-11T17:43:09Z

Also changes CI from travis to gh-actions

BeastyBlacksmith

@johnnychen94 I got around to give DemoCards.jl a go.

This is a mostly working version for GR alone, the titles look funny sometimes. Like Open/High/Low/Close

It would be nice to have different backends as tabs.

docs/make.jl

src/PlotDocs.jl

BeastyBlacksmith · 2021-12-16T16:15:31Z

Backends

GR
PyPlot
PlotlyJS Errors with ERROR: BoundsError: attempt to access 10-element Vector{Float64} at index [-1:8] in example 41 when creating the png file (fixed in Fix fillranges with OffsetVectors for plotly Plots.jl#4006)
PGFPlotsX runs longer than I am willing to wait ( after interrupting example 45 the page is built, but some examples have broken links, e.g. "Unconnected-lines-using-missing-or-NaN" )
InspectDR
Gaston Errors with MethodError: no method matching iterate(::Nothing) (worked around by showing png output)
UnicodePlots Doesn't error, but also doesn't produce any useful output

Create a preview via

rm("docs/gallery/generated", recursive = true); generate_cards(BACKEND); preview_demos("docs/gallery")

to get titles for empty cards you'd need (JuliaDocs/DemoCards.jl#103)

rm("docs/gallery/generated", recursive = true); generate_cards(BACKEND); preview_demos("docs/gallery");  preview_demos("docs/gallery")

where BACKEND is e.g. :gr or :pgfplotsx.

johnnychen94 · 2021-12-16T20:38:54Z

I'm glad that you have worked it out a few backends.

Sorry it's near the end of this semester and I can't comment much right now; I'll continue the work on DemoCards in Jan.

BeastyBlacksmith · 2022-01-07T16:41:45Z

This works now somewhat, but somehow all card links give a ERR_FILE_NOT_FOUND

* generate demo page per backend Instead of generating all backend demos in one demo page, this commit generates one page per backend. This makes exploring the demos easier. - entry "id" is added to resolve the url-link issue - notebook generation is disabled - attributes are generated as hidden page * Update PlotDocs.jl Co-authored-by: Simon Christ <SimonChrist@gmx.de>

BeastyBlacksmith · 2022-03-11T12:45:32Z

@johnnychen94 if I run make.jl I get the following error

ERROR: IOError: readdir("~/.julia/dev/PlotDocs.jl/docs/src/democards"): no such file or directory (ENOENT)
Stacktrace:
 [1] uv_error
   @ ./libuv.jl:97 [inlined]
 [2] readdir(dir::String; join::Bool, sort::Bool)
   @ Base.Filesystem ./file.jl:851
 [3] readdir
   @ ./file.jl:846 [inlined]
 [4] (::DemoCards.var"#107#111"{String, String, String, String, String, String, String, Vector{String}})()
   @ DemoCards ~/.julia/packages/DemoCards/w8V2k/src/generate.jl:214
 [5] (::var"#5#6")(cb::DemoCards.var"#107#111"{String, String, String, String, String, String, String, Vector{String}})
   @ Main ~/.julia/dev/PlotDocs.jl/docs/make.jl:103
 [6] foreach(f::var"#5#6", itr::Vector{Any})
   @ Base ./abstractarray.jl:2694
 [7] top-level scope
   @ ~/.julia/dev/PlotDocs.jl/docs/make.jl:101

johnnychen94 · 2022-03-11T12:54:20Z

This might due to the fact that all demo files are generated from another function generate_cards. The callbacks generated by DemoCards are not so smart to figure out the real source path.

foreach(galleries_cb) do cb
    # URL redirection for DemoCards-generated gallery
    cb()
end

The callbacks are currently specific to redirect the URL of "Edit on Github" button. A workaround is to not use the generated callbacks and manually remove this button in the generated HTML files.

BeastyBlacksmith · 2022-03-14T11:57:43Z

preview is up again: https://docs.juliaplots.org/previews/PR256/
I don't get, why I get the titles for skipped examples for GR but not for the other backends.

BeastyBlacksmith · 2022-03-14T12:27:04Z

Also I have trouble getting that custom stylesheet working, it always complains about having an absolute path, though I did specify a relative path

johnnychen94

I don't get, why I get the titles for skipped examples for GR but not for the other backends.

Would you mind pointing me to which case is broken? I'm not sure what is expected and what is not.

src/gallery_config.json

src/PlotDocs.jl

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>

BeastyBlacksmith · 2022-03-14T16:00:49Z

Would you mind pointing me to which case is broken? I'm not sure what is expected and what is not.

On the GR cards it shows e.g. "DataFrames" and the blank card, which is desired and on the PlotlyJS cards its "plotlyjs_ref25" and same for the other backends.

* use default order for demos By default DemoCards sort the demos by their filenames. * wrap source cards generation using IOBuffer For unknown reasons, the generated files are still empty when calling `makedemos` unless we wrap the `jl` file with IOBuffer. * correct backend name titlecase * try bulmagrid theme * add a few DemoCards comments * use empty card description * debug: try to sleep a while after each demo generation * restore order Co-authored-by: Simon Christ <SimonChrist@gmx.de>

BeastyBlacksmith · 2022-03-17T15:13:21Z

It seems I kinda broke github
feed84e not showing up here, can't reopen and opening a new PR errors out.

johnnychen94 · 2022-03-17T15:24:15Z

It seems I kinda broke github

Yes it is was broken https://www.githubstatus.com/

johnnychen94 · 2022-03-17T16:31:56Z

It seems everything works now.

From a user's perspective, I still dislike the empty cards; it feels like something is broken.

BeastyBlacksmith · 2022-03-17T16:36:45Z

From a user's perspective, I still dislike the empty cards; it feels like something is broken.

That's actually the point. To show what is working on which backend and what is not. This lets you quickly evaluate the expectation about the functionality of a backend by scrolling through the galllery.

BeastyBlacksmith added 3 commits August 11, 2021 19:42

Create docs.yml

463955a

Delete .travis.yml

bd47736

run on democards-branch

6a8db9d

BeastyBlacksmith mentioned this pull request Aug 11, 2021

Set up Plots gallery with DemoCards #255

Closed

BeastyBlacksmith and others added 4 commits August 11, 2021 19:48

remove hyphens

06d0ea6

a start

48e947f

usable gr-examples

03b1f7b

remove TagBot, add manual trigger to build

8ef2e48

BeastyBlacksmith commented Dec 16, 2021

View reviewed changes

docs/make.jl Outdated Show resolved Hide resolved

src/PlotDocs.jl Outdated Show resolved Hide resolved

BeastyBlacksmith added 6 commits December 16, 2021 11:16

fix #src

3e1f641

disable notebook generation

da495e6

specify order

4ac87d0

fix animations

074fac3

change back devbranch

ae4d76a

add attributes, empty cards, fix assets

6e88e0d

BeastyBlacksmith mentioned this pull request Dec 17, 2021

Fix fillranges with OffsetVectors for plotly JuliaPlots/Plots.jl#4006

Merged

BeastyBlacksmith added 2 commits December 17, 2021 17:50

don't write to file for unicodeplots

e3f5a53

add gaston workaround

baa84f9

Update docs.yml

67b2221

BeastyBlacksmith added the help wanted label Jan 17, 2022

BeastyBlacksmith mentioned this pull request Feb 16, 2022

Disable badges when disabling notebook creation JuliaDocs/DemoCards.jl#102

Closed

BeastyBlacksmith added 3 commits March 11, 2022 15:57

disable link redirection, add consistent order

cc0fd1f

Merge branch 'master' into democards

a9a8f9f

tweak configs

2d7e76c

johnnychen94 reviewed Mar 14, 2022

View reviewed changes

src/gallery_config.json Outdated Show resolved Hide resolved

src/PlotDocs.jl Outdated Show resolved Hide resolved

src/PlotDocs.jl Outdated Show resolved Hide resolved

Update src/PlotDocs.jl

a9574e2

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>

johnnychen94 mentioned this pull request Mar 17, 2022

patches for democards branch #276

Merged

johnnychen94 and others added 4 commits March 17, 2022 13:35

init order

8842544

mover order

0fd58d2

don't skip writing files

feed84e

BeastyBlacksmith closed this Mar 17, 2022

BeastyBlacksmith reopened this Mar 17, 2022

BeastyBlacksmith merged commit 60b7d48 into master Mar 17, 2022

BeastyBlacksmith deleted the democards branch March 17, 2022 17:04

This was referenced Mar 20, 2022

more robust callback implementation JuliaDocs/DemoCards.jl#107

Closed

run DemoCards callbacks #278

Merged

t-bltg mentioned this pull request Mar 28, 2022

Docs: Search results are hard to interpret for common search terms JuliaPlots/Plots.jl#4157

Closed

Branch for testing DemoCards.jl #256

Branch for testing DemoCards.jl #256

Uh oh!

Conversation

BeastyBlacksmith commented Aug 11, 2021

Uh oh!

BeastyBlacksmith left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BeastyBlacksmith commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backends

Uh oh!

johnnychen94 commented Dec 16, 2021

Uh oh!

BeastyBlacksmith commented Jan 7, 2022

Uh oh!

BeastyBlacksmith commented Mar 11, 2022

Uh oh!

johnnychen94 commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BeastyBlacksmith commented Mar 14, 2022

Uh oh!

BeastyBlacksmith commented Mar 14, 2022

Uh oh!

johnnychen94 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BeastyBlacksmith commented Mar 14, 2022

Uh oh!

BeastyBlacksmith commented Mar 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnnychen94 commented Mar 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnnychen94 commented Mar 17, 2022

Uh oh!

BeastyBlacksmith commented Mar 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BeastyBlacksmith left a comment •

edited

Loading

BeastyBlacksmith commented Dec 16, 2021 •

edited

Loading

johnnychen94 commented Mar 11, 2022 •

edited

Loading

BeastyBlacksmith commented Mar 17, 2022 •

edited

Loading

johnnychen94 commented Mar 17, 2022 •

edited

Loading