show headers during GithubException #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My python knowledge is getting in the way |
|
Why version of pygithub are we using in our CI here? |
|
1.54.1 which doesn't store headers |
|
😭 |
|
What's the first version of pygithub that stores the headers? |
| @@ -9,7 +9,7 @@ license = "MIT" | |||
| python = "^3.8" | |||
| Flask = "^1.1.2" | |||
| Jinja2 = "^2.11.2" | |||
| PyGithub = "^1.51" | |||
| PyGithub = "1.58.2" | |||
There was a problem hiding this comment.
Is it intentional that you dropped the caret?
There was a problem hiding this comment.
yes. 1.59 had breaking changes
|
woo. Now we just need someone with a failing TagBot to try this out by setting |
|
Or maybe we just release this as a patch and see in the wild |
|
Let's do it. It's green and we can revert in a patch if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to check for information we currently ignore that could investigate #298