-
Notifications
You must be signed in to change notification settings - Fork 20
Add elimination algorithms mcs
, rcm
, and mmd
.
#1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I saw the issue with |
More algorithms here. |
Hi, acknowledged thanks -- will look soon. Thanks for the contribution, more elimination algorithms are definitely good! |
Verson |
Update: I haven't forgotten -- been extra busy here with passing of a family member. Looking to work through this during travel this weekend. Apologies for the delay. |
I am sorry to hear that. Please take your time! |
Thanks for the contribution. Hangup was new ManifoldsBase v1 update happening simultaneously in related repos. Having to fix them all together. Apologies for the delay |
@@ -15,8 +15,8 @@ if TEST_GROUP in ["all", "basic_functional_group"] | |||
include("testSpecialEuclidean2Mani.jl") | |||
include("testEuclidDistance.jl") | |||
# gradient / jacobian tests | |||
include("manifolds/manifolddiff.jl") | |||
include("manifolds/factordiff.jl") | |||
#include("manifolds/manifolddiff.jl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will resolve these in separate PRs
This pull request adds some additional elimination algorithms:
mcs
: maximum cardinality searchrcm
: reverse Cuthill-Mckeemmd
: multiple minimum degreeThe first two algorithms were implemented by me, and the third was taken from Sparspak.jl and lightly edited. The third algorithm, in particular, is quite good: it was the state of the practice before AMD, and it has the advantage of being MIT licensed.