Closed
Conversation
The CPU path in getboxes previously processed entire image stacks at once, causing OOM on large inputs. This mirrors the GPU batching logic: - Use Sys.free_memory() to determine available RAM - Calculate batch size based on memory requirements (6x for standard, 10x for sCMOS) - Process large stacks in batches with proper frame offset tracking - Call GC.gc(false) between batches to release allocations Fixes issue #11. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
Superseded - CPU batching fix moved to PR #10 (tuple-pattern) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sys.free_memory()to determine available RAMGC.gc(false)between batches to release allocationsDetails
The CPU path in
getboxespreviously processed entire image stacks at once, which caused OOM errors on large inputs (e.g., 8.8GB input could spike to 37GB+ with DoG filter intermediates).Memory multipliers:
Test plan
🤖 Generated with Claude Code