Add the full status of the subsolver - #34
Conversation
Fix missing newline at end of file.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage ? 68.88%
=======================================
Files ? 11
Lines ? 585
Branches ? 0
=======================================
Hits ? 403
Misses ? 182
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@dpo Should we update the tests to test each status? Personally, I don't think it's necessary because each solver tests these statuses internally. |
| MadNLP.INVALID_NUMBER_DETECTED => :invalid_number, | ||
| MadNLP.ERROR_IN_STEP_COMPUTATION => :step_error, | ||
| MadNLP.INTERNAL_ERROR => :internal_error, | ||
| MadNLP.USER_REQUESTED_STOP => :user_stop, |
There was a problem hiding this comment.
| MadNLP.USER_REQUESTED_STOP => :user_stop, | |
| MadNLP.USER_REQUESTED_STOP => :user, |
Make sure the statuses match those here: https://github.com/JuliaSmoothOptimizers/SolverCore.jl/blob/main/src/stats.jl
|
Also, the Julia formatter isn’t happy. Check the “linting” job output. The best is to install pre_commit locally, as described in the BestieTemplate documentation. |
Updates the requirements on [TOML](https://github.com/JuliaLang/TOML.jl) to permit the latest version. - [Release notes](https://github.com/JuliaLang/TOML.jl/releases) - [Commits](https://github.com/JuliaLang/TOML.jl/commits) --- updated-dependencies: - dependency-name: TOML dependency-version: 1.0.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [MadNLP](https://github.com/MadNLP/MadNLP.jl) to permit the latest version. - [Release notes](https://github.com/MadNLP/MadNLP.jl/releases) - [Commits](https://github.com/MadNLP/MadNLP.jl/commits/v0.10.1) --- updated-dependencies: - dependency-name: MadNLP dependency-version: 0.10.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6 to 7. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v6...v7) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
2 participants
Description
This is a proposal for obtaining the exact status of the sub-solver. Before, we only had the keyword “:error,” which isn't very specific when we use Envelopt.jl in other algorithm or debugging.
Related issues
There is no related issue.
Checklist