fix: windows resource busy/locked #203
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testing in SciML/NonlinearSolve.jl#540 |
|
This fixes NonlinearSolve CI (see the 1.11 windows ones, 1.10 ones aren't using this patch) |
src/ReTestItems.jl
Outdated
| # See https://github.com/JuliaTesting/ReTestItems.jl/issues/124 | ||
| rm(logfile; force=true) # `force` to ignore error if file already cleaned up | ||
| catch err | ||
| @warn "Error while attempting to remove $(logfile)" err |
There was a problem hiding this comment.
Do we even need to log this to the user as a warning? is a @debug enough?
avik-pal
commented
Mar 17, 2025
|
I am not sure why CI is sad here |
|
This has been taking a long time to fix windows now... should we just drop windows? I think we should just drop windows testing at this point. |
nickrobinson251
approved these changes
Apr 6, 2025
|
Sorry i forgot about this -- CI is broken here for silly reasons and i forgot PRs were waiting, apologies. Merged and made a new release, and will try to get CI back online this week. Let me know if you need anything else fixing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #124