Skip to content

Conversation

@rofinn
Copy link
Member

@rofinn rofinn commented Aug 12, 2018

Closes #121

  • Replaced ZonedDateTime w/ Localized{<:AbstractDateTime}
  • We didn't need Localized/ZonedDateTime inner constructors, so turned them to outer constructors.
  • Renamed all variable references of zdt with ldt
  • Renamed '2' conversion methods to use localized rather than zdt

@omus
Copy link
Member

omus commented Aug 14, 2018

Thanks for the PR. I think we should sit on this for a little while as I'd like to experiment with Localized{Date} and Localized{Time} to avoid too much churn. Having a parameterized Localized type will allow us to support higher-accuracy instant types which will be much more compossible with other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants