Skip to content

Isolate authenticated proxy connection pools - #1329

Merged
quinnj merged 1 commit into
masterfrom
codex/isolate-authenticated-proxy-pools
Jul 10, 2026
Merged

Isolate authenticated proxy connection pools#1329
quinnj merged 1 commit into
masterfrom
codex/isolate-authenticated-proxy-pools

Conversation

@quinnj

@quinnj quinnj commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • assign an opaque identity to each authenticated proxy configuration
  • include that identity in HTTP/1 and HTTP/2 connection pool keys
  • cover SOCKS5/SOCKS5H and authenticated HTTP CONNECT configurations
  • verify credentials never appear in the generated pool key

Root cause

Proxy userinfo is deliberately removed from the normalized proxy URL, but that credential-free URL was also used as the connection pool identity. SOCKS and HTTP CONNECT authentication happens only while establishing the connection, so a later request using a different authenticated proxy configuration could reuse a connection established under the first configuration.

Impact

Authenticated proxy connections are now isolated by configuration without storing usernames, passwords, or reversible credential digests in internal pool keys. Reusing the same ProxyConfig still reuses its connections; independently parsed authenticated configurations are isolated conservatively.

Validation

  • full Pkg.test() on Julia 1.12, including all 63 trim-compilation checks
  • test/http_client_proxy_tests.jl on Julia 1.10
  • git diff --check

Co-authored by Codex

Assign an opaque identity to each authenticated proxy configuration and include it in the connection pool key. This prevents SOCKS5 and HTTP CONNECT connections from being reused across configurations without exposing credentials in internal keys.
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.08%. Comparing base (626dac7) to head (081cb9e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1329   +/-   ##
=======================================
  Coverage   88.08%   88.08%           
=======================================
  Files          30       30           
  Lines       11847    11849    +2     
=======================================
+ Hits        10435    10437    +2     
  Misses       1412     1412           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quinnj
quinnj marked this pull request as ready for review July 10, 2026 15:15
@quinnj
quinnj merged commit dabb567 into master Jul 10, 2026
8 checks passed
@quinnj
quinnj deleted the codex/isolate-authenticated-proxy-pools branch July 10, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant