Isolate authenticated proxy connection pools - #1329
Merged
Merged
Conversation
Assign an opaque identity to each authenticated proxy configuration and include it in the connection pool key. This prevents SOCKS5 and HTTP CONNECT connections from being reused across configurations without exposing credentials in internal keys.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
=======================================
Coverage 88.08% 88.08%
=======================================
Files 30 30
Lines 11847 11849 +2
=======================================
+ Hits 10435 10437 +2
Misses 1412 1412 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Proxy userinfo is deliberately removed from the normalized proxy URL, but that credential-free URL was also used as the connection pool identity. SOCKS and HTTP CONNECT authentication happens only while establishing the connection, so a later request using a different authenticated proxy configuration could reuse a connection established under the first configuration.
Impact
Authenticated proxy connections are now isolated by configuration without storing usernames, passwords, or reversible credential digests in internal pool keys. Reusing the same
ProxyConfigstill reuses its connections; independently parsed authenticated configurations are isolated conservatively.Validation
Pkg.test()on Julia 1.12, including all 63 trim-compilation checkstest/http_client_proxy_tests.jlon Julia 1.10git diff --checkCo-authored by Codex